Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump curl from 8.4.0 to 8.8.0 #205

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Bump curl from 8.4.0 to 8.8.0 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01e1fa
update curl to 8.8.0
ryfu-msft Jul 23, 2024
2c8a552
fix test
ryfu-msft Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cgmanifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"type": "git",
"git": {
"repositoryUrl": "https://github.com/curl/curl",
"commitHash": "d755a5f7c009dd63a61b2c745180d8ba937cbfeb"
"commitHash": "fd567d4f06857f4fc8e2f64ea727b1318f76ad33"
}
},
"developmentDependency": false
Expand All @@ -56,7 +56,7 @@
"type": "git",
"git": {
"repositoryUrl": "https://github.com/curl/curl",
"commitHash": "d755a5f7c009dd63a61b2c745180d8ba937cbfeb"
"commitHash": "fd567d4f06857f4fc8e2f64ea727b1318f76ad33"
}
}
]
Expand All @@ -75,7 +75,7 @@
"type": "git",
"git": {
"repositoryUrl": "https://github.com/curl/curl",
"commitHash": "d755a5f7c009dd63a61b2c745180d8ba937cbfeb"
"commitHash": "fd567d4f06857f4fc8e2f64ea727b1318f76ad33"
}
}
]
Expand Down
8 changes: 4 additions & 4 deletions client/tests/functional/details/CurlConnectionTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,11 @@ TEST("Testing a response over the limit fails the operation")
json body = {{{"TargetingAttributes", {}}, {"Product", largeProductName}}};
REQUIRE_NOTHROW(connection->Post(url, body.dump()));

// Over limit fails
// Going over the limit fails with a message like "client returned ERROR on write of 16384 bytes"
body[0]["Product"] = overLimitProductName;
REQUIRE_THROWS_CODE_MSG(connection->Post(url, body.dump()),
ConnectionUnexpectedError,
"Failure writing output to destination");
REQUIRE_THROWS_CODE_MSG_MATCHES(connection->Post(url, body.dump()),
ConnectionUnexpectedError,
Catch::Matchers::ContainsSubstring("client returned ERROR on write of"));
}

TEST("Testing MS-CV is sent to server")
Expand Down
2 changes: 1 addition & 1 deletion vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
},
{
"name": "curl",
"version": "8.4.0"
"version": "8.8.0"
},
{
"name": "nlohmann-json",
Expand Down