Bump curl from 8.4.0 to 8.8.0 (#205)

* update curl to 8.8.0 * fix test
microsoft · Jul 24, 2024 · 6ab78af · 6ab78af
1 parent 14b2b42
commit 6ab78af
Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/cgmanifest.json b/cgmanifest.json
@@ -37,7 +37,7 @@
         "type": "git",
         "git": {
           "repositoryUrl": "https://github.com/curl/curl",
-          "commitHash": "d755a5f7c009dd63a61b2c745180d8ba937cbfeb"
+          "commitHash": "fd567d4f06857f4fc8e2f64ea727b1318f76ad33"
         }
       },
       "developmentDependency": false
@@ -56,7 +56,7 @@
           "type": "git",
           "git": {
             "repositoryUrl": "https://github.com/curl/curl",
-            "commitHash": "d755a5f7c009dd63a61b2c745180d8ba937cbfeb"
+            "commitHash": "fd567d4f06857f4fc8e2f64ea727b1318f76ad33"
           }
         }
       ]
@@ -75,7 +75,7 @@
           "type": "git",
           "git": {
             "repositoryUrl": "https://github.com/curl/curl",
-            "commitHash": "d755a5f7c009dd63a61b2c745180d8ba937cbfeb"
+            "commitHash": "fd567d4f06857f4fc8e2f64ea727b1318f76ad33"
           }
         }
       ]

diff --git a/client/tests/functional/details/CurlConnectionTests.cpp b/client/tests/functional/details/CurlConnectionTests.cpp
@@ -316,11 +316,11 @@ TEST("Testing a response over the limit fails the operation")
     json body = {{{"TargetingAttributes", {}}, {"Product", largeProductName}}};
     REQUIRE_NOTHROW(connection->Post(url, body.dump()));
 
-    // Over limit fails
+    // Going over the limit fails with a message like "client returned ERROR on write of 16384 bytes"
     body[0]["Product"] = overLimitProductName;
-    REQUIRE_THROWS_CODE_MSG(connection->Post(url, body.dump()),
-                            ConnectionUnexpectedError,
-                            "Failure writing output to destination");
+    REQUIRE_THROWS_CODE_MSG_MATCHES(connection->Post(url, body.dump()),
+                                    ConnectionUnexpectedError,
+                                    Catch::Matchers::ContainsSubstring("client returned ERROR on write of"));
 }
 
 TEST("Testing MS-CV is sent to server")

diff --git a/vcpkg.json b/vcpkg.json
@@ -44,7 +44,7 @@
     },
     {
       "name": "curl",
-      "version": "8.4.0"
+      "version": "8.8.0"
     },
     {
       "name": "nlohmann-json",