.Net: Bump Cosmos package and use built-in serializer #8616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
westey-m
reviewed
Sep 9, 2024
dotnet/src/Connectors/Connectors.Memory.AzureCosmosDBNoSQL/AzureCosmosDBNoSQLMemoryStore.cs
Show resolved
Hide resolved
westey-m
approved these changes
Sep 9, 2024
dmytrostruk
reviewed
Sep 9, 2024
There was a problem hiding this comment.
@Pilchie Thanks for your contribution! Before merging to main, I will run our integration tests for this connector to double-check whether this change didn't impact anything and will get back to you shortly.
dmytrostruk
temporarily deployed
to
integration
GitHub Actions
Inactive
dmytrostruk
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
I can confirm that with this change integration tests are running successfully, and we can merge it to main branch. @Pilchie thanks again for your contribution!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure Cosmos DB released a new package that allows using System.Text.Json without manually defining a custom serializer. Update to that version and delete the code I copied from the Cosmos package before this was released.