.Net: Added additional data to auto function invocation filter context #7398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
.../SemanticKernel.Abstractions/Filters/AutoFunctionInvocation/AutoFunctionInvocationContext.cs
Show resolved
Hide resolved
RogerBarreto
approved these changes
Jul 23, 2024
westey-m
reviewed
Jul 23, 2024
westey-m
approved these changes
Jul 23, 2024
.../SemanticKernel.Abstractions/Filters/AutoFunctionInvocation/AutoFunctionInvocationContext.cs
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
Jul 23, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
microsoft#7398) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves: microsoft#7208 Added following data to auto function invocation filter context: - Tool Call ID - `ChatMessageContent` associated with function invocation operation Note: API compatibility suppression is required for `AutoFunctionInvocationContext` constructor to make `ChatMessageContent` required, since auto function invocation is happening only during chat completion operation, so `ChatMessageContent` should be always available. The reason why the constructor is public at the moment is because it lives in `Microsoft.SemanticKernel.Abstractions` package, while it is initialized in auto function calling logic in specific connector. When function calling abstraction will be in place, the constructor will be marked is `internal`, since `AutoFunctionInvocationContext` should not be created on user side. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves: #7208
Added following data to auto function invocation filter context:
ChatMessageContentassociated with function invocation operationNote: API compatibility suppression is required for
AutoFunctionInvocationContextconstructor to makeChatMessageContentrequired, since auto function invocation is happening only during chat completion operation, soChatMessageContentshould be always available. The reason why the constructor is public at the moment is because it lives inMicrosoft.SemanticKernel.Abstractionspackage, while it is initialized in auto function calling logic in specific connector. When function calling abstraction will be in place, the constructor will be marked isinternal, sinceAutoFunctionInvocationContextshould not be created on user side.Contribution Checklist