.Net: Handle missing operation id in OpenApi spec #7344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
markwallace-microsoft
force-pushed
the
users/markwallace/issue_7343
branch
2 times, most recently
from
8945772 to
a307893
Compare
…there is no operation id
markwallace-microsoft
force-pushed
the
users/markwallace/issue_7343
branch
from
a307893 to
4af5174
Compare
westey-m
approved these changes
Jul 18, 2024
SergeyMenshykh
approved these changes
Jul 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dmytrostruk
approved these changes
Jul 18, 2024
dotnet/src/Functions/Functions.OpenApi/OpenApiKernelPluginFactory.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
Jul 22, 2024
| foreach (string token in tokens) | ||
| { | ||
| // Removes all characters that are not ASCII letters, digits, and underscores. | ||
| string formattedToken = RemoveInvalidCharsRegex().Replace(token, ""); |
There was a problem hiding this comment.
nit. string.Empty
Suggested change
| string formattedToken = RemoveInvalidCharsRegex().Replace(token, ""); | |
| string formattedToken = RemoveInvalidCharsRegex().Replace(token, string.Empty); |
RogerBarreto
approved these changes
Jul 22, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context Closes microsoft#7343 Closes microsoft#5598 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #7343
Closes #5598
Description
Contribution Checklist