-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Weaviate memory connector http call optimization #7280
base: main
Are you sure you want to change the base?
.Net: Weaviate memory connector http call optimization #7280
Conversation
@westey-m, @RogerBarreto Can you please help me to test this current change? |
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs
Outdated
Show resolved
Hide resolved
…https://github.com/atiq-bs23/semantic-kernel into weaviate-memory-store-http-request-call-optimization
…https://github.com/atiq-bs23/semantic-kernel into weaviate-memory-store-http-request-call-optimization
@markwallace-microsoft all hard-coded null checks replaced. |
dotnet/src/Connectors/Connectors.Memory.Weaviate/Http/ApiSchema/BatchDeleteRequest.cs
Outdated
Show resolved
Hide resolved
@atiq-bs23, looks like there is an issue with the batch request model. I'm getting 422 (Unprocessable Entity) when running the integration tests. To run them yourself, check out https://github.com/microsoft/semantic-kernel/blob/main/dotnet/src/IntegrationTests/Connectors/Weaviate/WeaviateMemoryStoreTests.cs Steps are:
Let me know if you get stuck. |
…https://github.com/atiq-bs23/semantic-kernel into weaviate-memory-store-http-request-call-optimization
@westey-m based on their doc Batch delete objects , it seems the body is okay to me. Can you please check if there is anything I am missing? To generate the body please take the attachment Program.txt ->MAKE IT Program.cs -> Run as a console app JSON BODY In the meantime I will check weaviate docker image. |
…https://github.com/atiq-bs23/semantic-kernel into weaviate-memory-store-http-request-call-optimization
@westey-m Integration Test Passed dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateMemoryStore.cs#L394 Apologies for the late reply. We experienced an internet outage across Bangladesh for the past few days. |
@RogerBarreto could you please review this implementation when you have a chance? unit test and integration test passed. |
Motivation and Context
To improve efficiency and performance by reducing the number of HTTP requests during batch deletions in RemoveBatchAsync.
Description
The updated RemoveBatchAsync method in WeaviateMemoryStore now sends a single HTTP request to delete multiple keys at once, replacing the previous approach of sending individual requests for each key. This change minimizes network overhead and enhances performance.
Doc: Batch delete objects
Contribution Checklist