Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Upgrade .Net notebooks to Microsoft.SemanticKernel, 1.0.0-beta6 #3478

Merged
merged 6 commits into from
Nov 13, 2023
Merged

.Net: Upgrade .Net notebooks to Microsoft.SemanticKernel, 1.0.0-beta6 #3478

merged 6 commits into from
Nov 13, 2023

Conversation

markwallace-microsoft
Copy link
Member

@markwallace-microsoft markwallace-microsoft commented Nov 13, 2023 •
edited
Loading

Motivation and Context

Ensure .Net notebooks work with Microsoft.SemanticKernel, 1.0.0-beta6

  • Replace WithAzureXXX with WithAzureOpenAIXXX
  • Replace new PromptTemplate with promptTemplateFactory.Create

Contribution Checklist

@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Nov 13, 2023
@github-actions github-actions bot changed the title Upgrade .Net notebooks to Microsoft.SemanticKernel, 1.0.0-beta6 .Net: Upgrade .Net notebooks to Microsoft.SemanticKernel, 1.0.0-beta6 Nov 13, 2023
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/dotnet_notebooks_beta6 branch from fd53019 to f7959e2 Compare November 13, 2023 22:00
@markwallace-microsoft markwallace-microsoft marked this pull request as ready for review November 13, 2023 22:04
@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner November 13, 2023 22:04
RogerBarreto
RogerBarreto approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@RogerBarreto RogerBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLG

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Nov 13, 2023
Merged via the queue into microsoft:main with commit 9e7f550 Nov 13, 2023
18 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/dotnet_notebooks_beta6 branch November 13, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

@RogerBarreto RogerBarreto RogerBarreto approved these changes

@glahaye glahaye glahaye approved these changes

Assignees

@markwallace-microsoft markwallace-microsoft

Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markwallace-microsoft @glahaye @RogerBarreto @SergeyMenshykh @shawncal