Adds Intellij IDEA files to .gitignore #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnoliver
previously approved these changes
Nov 7, 2023
|
@agoncal I have had to move the pr to be against |
|
@johnoliver but this PR is not related with Java, it's for any developer using Intellij IDEA. Do I still need to use the |
johnoliver
approved these changes
Nov 7, 2023
dsgrieve
approved these changes
Nov 7, 2023
WeihanLi
reviewed
Nov 10, 2023
markwallace-microsoft
approved these changes
Nov 11, 2023
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context Intellij IDEA is heavy used in the Java ecosystem, so it would be good to have default files in the .gitignore ### Description Add the default Intellij IDEA working files and directory to the .gitignore ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Bruno Borges <brborges@microsoft.com> Co-authored-by: David Grieve <dsgrieve@yahoo.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context Intellij IDEA is heavy used in the Java ecosystem, so it would be good to have default files in the .gitignore ### Description Add the default Intellij IDEA working files and directory to the .gitignore ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Bruno Borges <brborges@microsoft.com> Co-authored-by: David Grieve <dsgrieve@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Intellij IDEA is heavy used in the Java ecosystem, so it would be good to have default files in the .gitignore
Description
Add the default Intellij IDEA working files and directory to the .gitignore
Contribution Checklist