Skip to content

.Net: Option #2 - Refactor to support generic LLM request settings (use object) #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Currently the SK core uses a model for LLM request settings which is OpenAI specific. This is a refactor to remove this assumption and to allow SK to be LLM agnostic.

Resolves: #2735

Description

  1. Remove ChatRequestSettings and CompleteRequestSettings and use dynamic instead
  2. Create default OpenAI request settings classes and code to create instance from an object. The object can be an instance of the expected request settings, a JsonElement or an anonymous type.
  3. Fix up planner, unit tests and integration tests
  4. Add a new Kernel syntax example showing all options to configure LLM request settings

Contribution Checklist

markwallace-microsoft and others added 30 commits September 10, 2023 17:02
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Sep 14, 2023
@markwallace-microsoft
Copy link
Member Author

See: #2829

@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/object_request_settings branch November 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompleteRequestSettings is insufficiently abstract
2 participants