-
Notifications
You must be signed in to change notification settings - Fork 3.8k
.Net: Option #2 - Refactor to support generic LLM request settings (use object) #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
markwallace-microsoft
wants to merge
35
commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/object_request_settings
Closed
.Net: Option #2 - Refactor to support generic LLM request settings (use object) #2819
markwallace-microsoft
wants to merge
35
commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/object_request_settings
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ynamic_request_settings
…github.com/markwallace-microsoft/semantic-kernel into users/markwallace/dynamic_request_settings
…markwallace/object_request_settings
See: #2829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently the SK core uses a model for LLM request settings which is OpenAI specific. This is a refactor to remove this assumption and to allow SK to be LLM agnostic.
Resolves: #2735
Description
ChatRequestSettings
andCompleteRequestSettings
and use dynamic insteadJsonElement
or an anonymous type.Contribution Checklist