Python: Add setup for contributing-python and tests for Semantic-Kernel-Python #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awharrison-28
requested changes
Aug 24, 2023
lemillermicrosoft
force-pushed
the
822_python_tasks
branch
from
9b7bd3c to
1dd13c4
Compare
shawncal
added
docs and tests
github-actions
bot
changed the title
awharrison-28
approved these changes
Aug 24, 2023
dmytrostruk
reviewed
Aug 29, 2023
Add setup tasks for contributing-python and tests for Semantic-Kernel-Python. The setup tasks install poetry and python packages. The tests include unit tests, integration tests, and all tests for Semantic-Kernel-Python.
Added two new tasks to the VS Code task configuration for Python code: one for formatting using the Ruff formatter, and one for validating using pre-commit hooks. These tasks will help ensure consistent and high-quality code contributions to the project.
- Removed instructions for running ruff - Updated label for validate task in VSCode tasks.json - Minor formatting changes The Python development setup documentation was updated to remove instructions for running ruff and to update the label for the validate task in the VSCode tasks.json file. Some minor formatting changes were also made.
This commit updates the formatting and arguments in the tasks.json file. Changes include adding new lines and spaces for better readability, and adjusting the arguments for the "test" tasks.
lemillermicrosoft
force-pushed
the
822_python_tasks
branch
from
c09a440 to
edc2a34
Compare
dmytrostruk
approved these changes
Aug 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
…el-Python (microsoft#2536) Add setup tasks for contributing-python and tests for Semantic-Kernel-Python. The setup tasks install poetry and python packages. The tests include unit tests, integration tests, and all tests for Semantic-Kernel-Python. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…el-Python (microsoft#2536) Add setup tasks for contributing-python and tests for Semantic-Kernel-Python. The setup tasks install poetry and python packages. The tests include unit tests, integration tests, and all tests for Semantic-Kernel-Python. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…el-Python (microsoft#2536) Add setup tasks for contributing-python and tests for Semantic-Kernel-Python. The setup tasks install poetry and python packages. The tests include unit tests, integration tests, and all tests for Semantic-Kernel-Python. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setup tasks for contributing-python and tests for Semantic-Kernel-Python. The setup tasks install poetry and python packages. The tests include unit tests, integration tests, and all tests for Semantic-Kernel-Python.
Contribution Checklist