Extracting plan json from ActionPlanner result #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teresaqhoang
added
planner
github-actions
bot
added
.NET
dmytrostruk
reviewed
Jul 3, 2023
There was a problem hiding this comment.
Thanks @teresaqhoang !
It would be great to add unit test under Extensions.UnitTests\Planning to verify and showcase how new regex resolves an issue.
dmytrostruk
added
the
PR: feedback to address
teresaqhoang
added
PR: ready to merge
…aqhoang/semantic-kernel into action-planner-json-parser
dmytrostruk
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Thanks @teresaqhoang ! I pushed some minor improvements for tests and XML documentation. Looks good to me!
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> LLM can return additional texts (i.e., preambles, explanations) around the proposed plan, so this PR extracts a well-formed JSON from the result of the planner using a RegEx and balanced group concepts. In response to: microsoft#1726 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Also, updates any use of Plan State to Plan Parameters due to previous Planner refactor. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
|
Which version of semantic kernel is this issue resolved in, using 0.5.1.dev0 I am still seeing error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
LLM can return additional texts (i.e., preambles, explanations) around the proposed plan, so this PR extracts a well-formed JSON from the result of the planner using a RegEx and balanced group concepts.
In response to: #1726
Description
Also, updates any use of Plan State to Plan Parameters due to previous Planner refactor.
Contribution Checklist
dotnet format