Skip to content

.Net: Update default OpenAI image model to gpt-image-2 #14530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

.Net: Update default OpenAI image model to gpt-image-2 #14530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions dotnet/src/Connectors/Connectors.OpenAI.UnitTests/Services/OpenAITextToImageServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,18 @@ public OpenAITextToImageServiceTests()
this._mockLoggerFactory = new Mock<ILoggerFactory>();
}

[Fact]
public void ConstructorWorksCorrectly()
[Theory]
[InlineData(null, "gpt-image-2")]
[InlineData("model", "model")]
public void ConstructorWorksCorrectly(string? modelId, string expectedModelId)
{
// Arrange & Act
var sut = new OpenAITextToImageService("apiKey", "organization", "model");
var sut = new OpenAITextToImageService("apiKey", "organization", modelId);

// Assert
Assert.NotNull(sut);
Assert.Equal("organization", sut.Attributes[ClientCore.OrganizationKey]);
Assert.Equal("model", sut.Attributes[AIServiceExtensions.ModelIdKey]);
Assert.Equal(expectedModelId, sut.Attributes[AIServiceExtensions.ModelIdKey]);
}

[Theory]
Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/Connectors/Connectors.OpenAI/Core/ClientCore.TextToImage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ internal async Task<string> GenerateImageAsync(
};

// The model is not required by the OpenAI API and defaults to the DALL-E 2 server-side - https://platform.openai.com/docs/api-reference/images/create#images-create-model.
// However, considering that the model is required by the OpenAI SDK and the ModelId property is optional, it defaults to gpt-image-1 in the line below.
targetModel = string.IsNullOrEmpty(targetModel) ? "gpt-image-1" : targetModel!;
// However, considering that the model is required by the OpenAI SDK and the ModelId property is optional, it defaults to gpt-image-2 in the line below.
targetModel = string.IsNullOrEmpty(targetModel) ? "gpt-image-2" : targetModel!;

ClientResult<GeneratedImage> response = await RunRequestAsync(() => this.Client!.GetImageClient(targetModel).GenerateImageAsync(prompt, imageOptions, cancellationToken)).ConfigureAwait(false);
var generatedImage = response.Value;
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/Connectors/Connectors.OpenAI/Services/OpenAITextToImageService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public OpenAITextToImageService(
HttpClient? httpClient = null,
ILoggerFactory? loggerFactory = null)
{
this._client = new(modelId ?? "gpt-image-1", apiKey, organization, null, httpClient, loggerFactory?.CreateLogger(this.GetType()));
this._client = new(modelId ?? "gpt-image-2", apiKey, organization, null, httpClient, loggerFactory?.CreateLogger(this.GetType()));
}

/// <inheritdoc/>
Expand Down
Loading