GitHub Repo Q&A: Fixed issue that prevents choosing and saving an OpenAI completions model. #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the chat completions endpoint rather than the text completions endpoint.
adrianwyatt
added
the
PR: ready for review
adrianwyatt
approved these changes
Jun 1, 2023
adrianwyatt
added
PR: ready to merge
salmon131
pushed a commit
to salmon131/semantic-kernel
that referenced
this pull request
Jun 3, 2023
…nAI completions model. (microsoft#1305) ### Motivation and Context When using OpenAI in the GitHub Repo Q&A sample, an error occurs when a valid chat completions model is chosen from the dropdown list. Furthermore, selecting a text completions model passes validation but causes a bad request error when saving. ### Description Fixed issue by updating the model validation function to test model selection against the chat completions endpoint rather than the text completions endpoint.
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…nAI completions model. (microsoft#1305) ### Motivation and Context When using OpenAI in the GitHub Repo Q&A sample, an error occurs when a valid chat completions model is chosen from the dropdown list. Furthermore, selecting a text completions model passes validation but causes a bad request error when saving. ### Description Fixed issue by updating the model validation function to test model selection against the chat completions endpoint rather than the text completions endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When using OpenAI in the GitHub Repo Q&A sample, an error occurs when a valid chat completions model is chosen from the dropdown list. Furthermore, selecting a text completions model passes validation but causes a bad request error when saving.
Description
Fixed issue by updating the model validation function to test model selection against the chat completions endpoint rather than the text completions endpoint.
Contribution Checklist
dotnet format