Skip to content

.Net: Fix AggregatorKernelAgentFactory naming#13018

Merged
markwallace-microsoft merged 1 commit intomicrosoft:mainfrom
markwallace-microsoft:users/markwallace/fix_AggregatorKernelAgentFactory_Naming
Aug 27, 2025
Merged

.Net: Fix AggregatorKernelAgentFactory naming#13018
markwallace-microsoft merged 1 commit intomicrosoft:mainfrom
markwallace-microsoft:users/markwallace/fix_AggregatorKernelAgentFactory_Naming

Conversation

@markwallace-microsoft
Copy link
Copy Markdown
Contributor

Motivation and Context

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner August 27, 2025 09:20
@moonbox3 moonbox3 added the .NET Issue or Pull requests regarding .NET code label Aug 27, 2025
@github-actions github-actions bot changed the title Fix AggregatorKernelAgentFactory naming .Net: Fix AggregatorKernelAgentFactory naming Aug 27, 2025
Copy link
Copy Markdown
Member

@rogerbarreto rogerbarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this will not bring any type collision in another namespace, LGTM

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Aug 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
@markwallace-microsoft
Copy link
Copy Markdown
Contributor Author

Merge failed due to unrelated integration test failure

[xUnit.net 00:04:49.42]            at Microsoft.SemanticKernel.Connectors.OpenAI.ClientCore.RunRequestAsync[T](Func`1 request)
  Passed SemanticKernel.IntegrationTests.Agents.CommonInterfaceConformance.AgentThreadConformance.AzureAIAgentThreadTests.DeletingThreadTwiceDoesNotThrowAsync [184 ms]
  Failed SemanticKernel.IntegrationTests.Connectors.AzureOpenAI.AzureOpenAITextToImageTests.ItCanReturnImageUrlAsync [2 s]
  Error Message:
   Microsoft.SemanticKernel.HttpOperationException : HTTP 500 (: internalFailure)

@markwallace-microsoft markwallace-microsoft merged commit 3ceceec into microsoft:main Aug 27, 2025
21 checks passed
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants