.Net: Bug: Qdrant DateTime Range filter set incorrectly#12936
Merged
westey-m merged 1 commit intomicrosoft:mainfrom Aug 19, 2025
Merged
.Net: Bug: Qdrant DateTime Range filter set incorrectly#12936westey-m merged 1 commit intomicrosoft:mainfrom
westey-m merged 1 commit intomicrosoft:mainfrom
Conversation
TsengSR
force-pushed
the
bugfixes/qdrant-datetimeoffset-filter
branch
from
b48147e to
897c9de
Compare
Contributor
Author
|
@microsoft-github-policy-service agree |
TsengSR
changed the title
TsengSR
force-pushed
the
bugfixes/qdrant-datetimeoffset-filter
branch
from
897c9de to
7cdf009
Compare
westey-m
reviewed
Aug 15, 2025
TsengSR
force-pushed
the
bugfixes/qdrant-datetimeoffset-filter
branch
from
7cdf009 to
28b0fcc
Compare
westey-m
approved these changes
Aug 18, 2025
markwallace-microsoft
approved these changes
Aug 19, 2025
rogerbarreto
approved these changes
Aug 19, 2025
Contributor
|
Thanks for the contribution @TsengSR. This will be part of our next release, which should be later today if all goes well. |
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
) ### Motivation and Context Fixes microsoft#12934 The filter translation layer set all 4 (Gt, Gte, Lt, Lte) properties of the datetime range object, which resulted in always 0 results being returned as no rows can be greater and smaller than the set date at the same time. ### Description At first I added some simple tests and an `DateTimeOffset` properties to the unit tests, which failed. After debugging and finding the issue, I made the changes and the tests passed. I was only able to test the Qdrant and InMemory integrations though, due to lack of locally running and preconfigured databases. **Open** ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: TsengSR <kpgit@atomic-gear.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #12934
The filter translation layer set all 4 (Gt, Gte, Lt, Lte) properties of the datetime range object, which resulted in always 0 results being returned as no rows can be greater and smaller than the set date at the same time.
Description
At first I added some simple tests and an
DateTimeOffsetproperties to the unit tests, which failed. After debugging and finding the issue, I made the changes and the tests passed.I was only able to test the Qdrant and InMemory integrations though, due to lack of locally running and preconfigured databases.
Open
Contribution Checklist