-
Notifications
You must be signed in to change notification settings - Fork 3.9k
.Net: Start to add integration tests #12272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markwallace-microsoft
merged 6 commits into
microsoft:feature-openai-responses-agent
from
markwallace-microsoft:users/markwallace/integration_tests
May 28, 2025
Merged
.Net: Start to add integration tests #12272
markwallace-microsoft
merged 6 commits into
microsoft:feature-openai-responses-agent
from
markwallace-microsoft:users/markwallace/integration_tests
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces integration tests for the OpenAI response agents and updates some agent test configurations for improved flexibility and error handling.
- Updated BaseResponsesAgentTest to use a configuration-based model id.
- Added multiple integration test files for verifying OpenAIResponseAgent behavior and thread conformance.
- Updated OpenAIResponseAgentThread to expose a public CreateAsync method and improve deletion error handling.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
dotnet/src/InternalUtilities/samples/AgentUtilities/BaseResponsesAgentTest.cs | Replaced hardcoded model string with configuration value. |
dotnet/src/IntegrationTests/Agents/OpenAIResponseAgentTests.cs | Added integration tests for agent invocation and streaming responses. |
dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/OpenAIResponsesAgentFixture.cs | Introduced a fixture to centralize test setup and teardown for OpenAI agent tests. |
dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/AgentThreadConformance/OpenAIResponseAgentThreadTests.cs | Added tests focused on agent thread behavior conformance. |
dotnet/src/Agents/OpenAI/OpenAIResponseAgentThread.cs | Added a public CreateAsync method and improved error handling during deletion with a try/catch block. |
dotnet/src/Agents/OpenAI/OpenAIResponseAgentInvokeOptions.cs | Added a new class to encapsulate extra invocation options for the agent. |
westey-m
reviewed
May 27, 2025
westey-m
approved these changes
May 27, 2025
SergeyMenshykh
approved these changes
May 27, 2025
shethaadit
approved these changes
May 28, 2025
Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
32e618b
into
microsoft:feature-openai-responses-agent
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist