Skip to content

.Net: Start to add integration tests #12272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner May 26, 2025 15:30
@markwallace-microsoft markwallace-microsoft requested review from Copilot and removed request for a team May 26, 2025 15:30
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels May 26, 2025
@github-actions github-actions bot changed the title Start to add integration tests .Net: Start to add integration tests May 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces integration tests for the OpenAI response agents and updates some agent test configurations for improved flexibility and error handling.

  • Updated BaseResponsesAgentTest to use a configuration-based model id.
  • Added multiple integration test files for verifying OpenAIResponseAgent behavior and thread conformance.
  • Updated OpenAIResponseAgentThread to expose a public CreateAsync method and improve deletion error handling.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
dotnet/src/InternalUtilities/samples/AgentUtilities/BaseResponsesAgentTest.cs Replaced hardcoded model string with configuration value.
dotnet/src/IntegrationTests/Agents/OpenAIResponseAgentTests.cs Added integration tests for agent invocation and streaming responses.
dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/OpenAIResponsesAgentFixture.cs Introduced a fixture to centralize test setup and teardown for OpenAI agent tests.
dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/AgentThreadConformance/OpenAIResponseAgentThreadTests.cs Added tests focused on agent thread behavior conformance.
dotnet/src/Agents/OpenAI/OpenAIResponseAgentThread.cs Added a public CreateAsync method and improved error handling during deletion with a try/catch block.
dotnet/src/Agents/OpenAI/OpenAIResponseAgentInvokeOptions.cs Added a new class to encapsulate extra invocation options for the agent.

Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
@markwallace-microsoft markwallace-microsoft merged commit 32e618b into microsoft:feature-openai-responses-agent May 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants