.Net: Sync to MEAI 9.3.0-preview.1.25114.11 #10989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
roji
commented
Mar 14, 2025
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceExtensions.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatClientChatCompletionService.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.UnitTests/AI/ServiceConversionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
Member
Thanks! You beat me to it. I was waiting for a new build of ONNXRuntimeGenAI to be available, as I expect there will be versioning issues without that. It's supposed to be out today. |
stephentoub
reviewed
Mar 14, 2025
stephentoub
reviewed
Mar 14, 2025
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatClientChatCompletionService.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 14, 2025
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 14, 2025
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs
Show resolved
Hide resolved
roji
commented
Mar 14, 2025
dotnet/src/SemanticKernel.Abstractions/Contents/KernelContent.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/BinaryContent.cs
Outdated
Show resolved
Hide resolved
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
Member
|
@markwallace-microsoft, @rogerbarreto, are there known issues with the Process tests? I'm not familiar with that part of the codebase, but it's not clear to me why it would be impacted at all by the changes in this PR. |
dotnet/src/Connectors/Connectors.Ollama.UnitTests/Services/OllamaChatCompletionTests.cs
Show resolved
Hide resolved
Member
I saw that, will have a look, thought the same |
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
had a problem deploying
to
integration
GitHub Actions
Failure
markwallace-microsoft
had a problem deploying
to
integration
GitHub Actions
Failure
rogerbarreto
had a problem deploying
to
integration
GitHub Actions
Failure
markwallace-microsoft
had a problem deploying
to
integration
GitHub Actions
Failure
rogerbarreto
approved these changes
Mar 18, 2025
markwallace-microsoft
approved these changes
Mar 18, 2025
Member
|
The PR is building now. We should definitely revisit the 512e76b commit, though, after today's release is unblocked. It seems like there's some kind of conflict in the OllamaSharp package due to it carrying a source generator that depends on versions of compiler binaries that are incompatible with other aspect's of the repo's build. This was the way I found to temporarily work around it (other things I tried like excluding the analyzer assets for OllamaSharp were insufficient), but I don't like it as a longer-term solution. |
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
A good review would be much appreciated, including considering the higher-level implications of the MEAI-side change for SK (I know very little about SK outside of MEVD!). See specific comments below. --------- Co-authored-by: Stephen Toub <stoub@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good review would be much appreciated, including considering the higher-level implications of the MEAI-side change for SK (I know very little about SK outside of MEVD!). See specific comments below.