Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Bedrock agent #10307

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented Jan 27, 2025

Motivation and Context

Address #10284

Integration of AWS Bedrock agent to SK Python

Description

  1. Implementation of Bedrock agent in SK (essentially an agent connector to the Bedrock agent service).
  2. A dedicated channel that works with Bedrock agents.
  3. Samples on how to use Bedrock agents.

Unit and integration tests will be included in another PR to prevent this PR from becoming too big.

Contribution Checklist

@TaoChenOSU TaoChenOSU added PR: in progress Under development and/or addressing feedback python Pull requests for the Python Semantic Kernel labels Jan 27, 2025
@TaoChenOSU TaoChenOSU self-assigned this Jan 27, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner January 27, 2025 18:31
@github-actions github-actions bot changed the title [WIP] Bedrock agent Python: [WIP] Bedrock agent Jan 27, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 27, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents
   agent.py57198%82
semantic_kernel/agents/bedrock
   action_group_utils.py28280%3–108
   bedrock_agent.py1831830%4–585
   bedrock_agent_base.py1621620%3–436
   bedrock_agent_settings.py880%3–33
semantic_kernel/agents/bedrock/models
   bedrock_action_group_model.py880%3–21
   bedrock_agent_event_type.py880%3–19
   bedrock_agent_model.py11110%3–24
   bedrock_agent_status.py12120%4–23
semantic_kernel/agents/channels
   bedrock_agent_channel.py80800%3–209
   chat_history_channel.py79297%167, 170
semantic_kernel/agents/chat_completion
   chat_completion_agent.py102793%82, 85, 94–99, 124, 189
TOTAL17596236187% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3048 4 💤 0 ❌ 0 🔥 1m 21s ⏱️

@TaoChenOSU TaoChenOSU changed the title Python: [WIP] Bedrock agent Python: Bedrock agent Jan 30, 2025
Comment on lines +63 to +64
"google-cloud-aiplatform == 1.60",
"google-generativeai == 0.7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing these versions because the latest compatible versions will break mypy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation PR: in progress Under development and/or addressing feedback python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants