Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Refactor shared integration tests to allow attribute based disable. #10236

Merged
merged 3 commits into from
Jan 21, 2025
Merged

.Net: Refactor shared integration tests to allow attribute based disable. #10236

merged 3 commits into from
Jan 21, 2025

Conversation

westey-m
Copy link
Contributor

Description

  • Moved and renamed pinecone xunit helpers a level up.
  • Added an attribute to allow all tests with VectorStoreFact / Theory in a class to be disabled, even ones in the base class

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner January 20, 2025 17:05
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jan 20, 2025
@github-actions github-actions bot changed the title Refactor shared integration tests to allow attribute based disable. .Net: Refactor shared integration tests to allow attribute based disable. Jan 20, 2025
@westey-m westey-m added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@westey-m westey-m added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@westey-m westey-m added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@westey-m westey-m added this pull request to the merge queue Jan 21, 2025
Merged via the queue into microsoft:main with commit 9f0ee59 Jan 21, 2025
17 checks passed
@westey-m westey-m deleted the vector-store-integration-disable branch January 21, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westey-m @SergeyMenshykh @markwallace-microsoft