Ensure the SK is built for JDK 8 release (#1394)

Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
microsoft · Jun 12, 2023 · 825cbca · 825cbca
1 parent 9e40446
commit 825cbca
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/java/api-test/pom.xml b/java/api-test/pom.xml
@@ -17,6 +17,7 @@
     <packaging>pom</packaging>
 
     <properties>
+        <maven.compiler-plugin.version>3.11.0</maven.compiler-plugin.version>
         <maven.compiler.release>17</maven.compiler.release>
     </properties>
 
@@ -37,4 +38,19 @@
         </dependencies>
     </dependencyManagement>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <version>${maven.compiler-plugin.version}</version>
+                <configuration>
+                    <source>${maven.compiler.release}</source>
+                    <target>${maven.compiler.release}</target>
+                    <release>${maven.compiler.release}</release>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
 </project>
diff --git a/java/pom.xml b/java/pom.xml
@@ -187,6 +187,7 @@
                     <configuration>
                         <source>${maven.compiler.release}</source>
                         <target>${maven.compiler.release}</target>
+                        <release>8</release>
                     </configuration>
                 </plugin>
                 <plugin>
@@ -538,6 +539,8 @@
                         <configuration>
                             <source>${maven.compiler.release}</source>
                             <target>${maven.compiler.release}</target>
+                            <!-- Ensure we compile against JDK 8 APIs -->
+                            <release>8</release>
                             <encoding>${project.build.sourceEncoding}</encoding>
                             <showWarnings>true</showWarnings>
                             <compilerArgs>

diff --git a/java/samples/pom.xml b/java/samples/pom.xml
@@ -17,9 +17,8 @@
         <com.uber.nullaway.version>0.10.10</com.uber.nullaway.version>
         <google.errorprone.core.version>2.19.1</google.errorprone.core.version>
         <log4j2.version>2.20.0</log4j2.version>
-        <maven.compiler.plugin.version>3.11.0</maven.compiler.plugin.version>
+        <maven.compiler-plugin.version>3.11.0</maven.compiler-plugin.version>
         <maven.compiler.release>17</maven.compiler.release>
-        <maven.compiler.source>17</maven.compiler.source>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <maven.compiler.target>17</maven.compiler.target>
     </properties>
@@ -36,6 +35,21 @@
         </dependencies>
     </dependencyManagement>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <version>${maven.compiler-plugin.version}</version>
+                <configuration>
+                    <source>${maven.compiler.release}</source>
+                    <target>${maven.compiler.release}</target>
+                    <release>${maven.compiler.release}</release>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
     <dependencies>
         <dependency>
             <groupId>com.microsoft.semantickernel</groupId>