Skip to content

Commit

Permalink
Python: Revert Pysdk issue 3980 (#5063) (#5119)
Browse files Browse the repository at this point in the history
This reverts commit ce1ebe1.

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
  • Loading branch information
moonbox3 authored Feb 22, 2024
1 parent ce1ebe1 commit 8079755
Show file tree
Hide file tree
Showing 6 changed files with 56 additions and 113 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/python-coverage.yml

This file was deleted.

19 changes: 0 additions & 19 deletions .github/workflows/python-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ jobs:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
os: [ubuntu-latest, windows-latest, macos-latest]
permissions:
pull-requests: write
contents: write

steps:
- uses: actions/checkout@v4
Expand All @@ -33,19 +30,3 @@ jobs:
- name: Test with pytest
run: |
cd python && poetry run pytest ./tests/unit
- name: Coverage comment
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.11'
id: coverage_comment
uses: py-cov-action/python-coverage-comment-action@v3
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
# If you use a different name, update COMMENT_ARTIFACT_NAME accordingly
name: python-coverage-comment-action
# If you use a different name, update COMMENT_FILENAME accordingly
path: python-coverage-comment-action.txt
1 change: 0 additions & 1 deletion python/.coveragerc
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[run]
source = semantic_kernel
relative_files = true
omit =
semantic_kernel/connectors/memory/*
semantic_kernel/connectors/openapi/*
Expand Down
15 changes: 0 additions & 15 deletions python/DEV_SETUP.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,21 +121,6 @@ You can also run all the tests together under the [tests](tests/) folder.

## Tools and scripts

### Pre-commit Hooks

As their name suggests, pre-commit hooks run before the commit process and it is a great way to make sure your code is ready to be committed.

To install pre-commit hook, you can check [the installation guide](https://pre-commit.com/#install) for platform-specific instructions.

The pre-commit configuration file for this SDK locates in the `.conf` folder and it depends on GitHub's out-of-box [pre-commit hooks](https://github.com/pre-commit/pre-commit-hooks), [black](https://github.com/psf/black) and [ruff](https://github.com/astral-sh/ruff-pre-commit).

To config pre-commit to use the configuration file:

```
cd .conf
pre-commit install
```

## Implementation Decisions

### Asynchronous programming
Expand Down
Loading

0 comments on commit 8079755

Please sign in to comment.