[playwright-browser-tunnel] Add playwright-versioning and remove semver-coersion#5669
Merged
TheLarkInn merged 3 commits intomicrosoft:mainfrom Feb 25, 2026
Merged
Conversation
Allow manually passing in the version of playwright to use for the tunnel and still default to the playwright-core version if not provided. This allows us to use the tunnel with different versions of playwright without needing to update the tunnel package itself.
Remove semver coercion from the Playwright version in the handshake message. This allows for more flexible version handling and avoids issues with prerelease version formats.
anarmawala
requested review from
apostolisms,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
TheLarkInn
approved these changes
Feb 24, 2026
Member
TheLarkInn
left a comment
TheLarkInn
left a comment
There was a problem hiding this comment.
Will need rush change for the playwright-browser-tunnel for CI to pass, but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First Fix:
Make sure tunneledBrowserConnection takes in a playwright version to manually use but still default to playwright-core version for added flexibility.
Second Fix:
Semver currently does not properly parse prerelease versions and thus the playwright versions are improperly guessed leading to crashes and schema errors.
How it was tested
Using the lauched option for the vscode extension.
Impacted documentation
N/A