fix: normalize temporary directory path handling for remote environments #5588
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where fancy terminal prompts (like oh-my-zsh or oh-my-posh) add extra characters to terminal output, breaking the parsing of the temporary directory path in remote environments. The fix implements a marker-based parsing approach similar to the one used in the debug-certificate-manager extension, wrapping the Node.js output with unique markers (<<<TEMPDIR_START>>> and <<<TEMPDIR_END>>>) to reliably extract the temp directory path from noisy terminal output.
Changes:
- Added marker-based parsing to extract temp directory path from terminal output in remote environments
- Implemented proper extraction logic using string markers to handle terminal decorations from fancy prompts
vscode-extensions/playwright-local-browser-server-vscode-extension/src/extension.ts
Show resolved
Hide resolved
anarmawala
approved these changes
Feb 3, 2026
Member
Author
|
@bmiddha commented that we should abstract this logic if we're using it more than once, I'll come up with a couple ideas for this |
bmiddha
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fancy terminals like oh-my-zsh or oh-my-posh will add extra characters onto terminal output. Which isn't friendly with runWorkspaceCommandAsync
This PR uses the same functionality as debug-cert-extension.
Example of the bug (see the URI in terminal)
