[heft-webpack5-plugin] allow infrastructure logs to be printed #5402
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
aramissennyeydd
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
iclanton
approved these changes
Oct 7, 2025
...n/changes/@rushstack/heft-webpack5-plugin/sennyeya-fix-webpack-logging_2025-10-06-19-24.json
Outdated
Show resolved
Hide resolved
…bpack-logging_2025-10-06-19-24.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Have been noticing this for a while, we fixed this with a recent fork of this plugin to support Rspack and wanting to contribute this back as we still have folks on the webpack plugin. Basically, by tapping the hook and returning true, we're consuming all events and not letting webpack actually print them. Removing the
return truefixes the issue.Details
How it was tested
Tested in our monorepo that
webpack-dev-middlewarelogs for HTTP requests were getting printed with this change and were not getting printed without this change.Impacted documentation