Skip to content

[rush] Clarify the copyright notice in common/scripts/*.js - #4623

Merged
octogonz merged 2 commits into
mainfrom
octogonz/common-scripts-copyright
Apr 6, 2024
Merged

[rush] Clarify the copyright notice in common/scripts/*.js#4623
octogonz merged 2 commits into
mainfrom
octogonz/common-scripts-copyright

Conversation

@octogonz

@octogonz octogonz commented Apr 5, 2024

Copy link
Copy Markdown
Collaborator

Summary

PR #4348 changed the copyright notice that appears in common/scripts/*.js to say:

new text

// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
// See LICENSE in the project root for license information.

...instead of...

old text

// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
// See the @microsoft/rush package's LICENSE file for license information.

This text is misleading -- what is the "project root" for install-run.js?

Details

This PR restores an appropriate copyright notice.

@iclanton

@octogonz
octogonz enabled auto-merge April 5, 2024 04:49
octogonz added a commit to microsoft/rush-example that referenced this pull request Apr 5, 2024
@octogonz

octogonz commented Apr 5, 2024

Copy link
Copy Markdown
Collaborator Author

Here's a diff showing the effects of this PR:

microsoft/rush-example@main...octogonz/pr-4623

@octogonz
octogonz merged commit db8a195 into main Apr 6, 2024
@octogonz
octogonz deleted the octogonz/common-scripts-copyright branch April 6, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants