Skip to content

Conversation

@octogonz
Copy link
Collaborator

@octogonz octogonz commented Oct 19, 2017

We need an easier way for people to invoke the api-documenter tool, that does not require enlisting and building the product code.

This PR also moves/renames some source files to make the project easier to understand.

@octogonz octogonz requested review from iclanton and qz2017 October 19, 2017 20:08
@octogonz octogonz changed the base branch from master to pgonzal/ae-command-line October 19, 2017 20:09
Copy link
Contributor

@qz2017 qz2017 Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name "ad" is kind of too brief. #WontFix

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real executable is "api-documenter". This ad.cmd file is just used by me to invoke the tool locally when debugging it.


In reply to: 145812638 [](ancestors = 145812638)

@iclanton
Copy link
Member

iclanton commented Oct 19, 2017

Add the real binary and make sure it's not gitignored. #Resolved


Refers to: libraries/api-documenter/ad.cmd:4 in 7a13657. [](commit_id = 7a1365775bca424fbec28c395c6157e9f6eb944d, deletion_comment = False)

Copy link
Member

@iclanton iclanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@octogonz octogonz force-pushed the pgonzal/ad-command-line branch from c6e4a6b to 989ed38 Compare October 20, 2017 00:48
@octogonz octogonz changed the base branch from pgonzal/ae-command-line to master October 20, 2017 01:12
@octogonz
Copy link
Collaborator Author

octogonz commented Oct 20, 2017

:shipit:

Approved with PullApprove Approved with PullApprove

@octogonz octogonz merged commit a6af441 into master Oct 20, 2017
@iclanton iclanton deleted the pgonzal/ad-command-line branch November 1, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants