[rush-lib] Add flags for parameters to rush telemetry #2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPapp-MS
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
iclanton
reviewed
Aug 6, 2021
common/changes/@microsoft/rush/benpapp-AddFlagsToRushTelemetry_2021-08-05-20-52.json
Outdated
Show resolved
Hide resolved
…_2021-08-05-20-52.json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
…BPapp-MS/rushstack into benpapp/AddFlagsToRushTelemetry
iclanton
reviewed
Aug 17, 2021
iclanton
reviewed
Aug 17, 2021
iclanton
reviewed
Aug 18, 2021
iclanton
approved these changes
Aug 18, 2021
BPapp-MS
changed the title
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users are not at the moment able to record telemetry on the parameters used by rush install/update, including whether the project selection parameters such as --to or --from are getting use. This PR adds many parameters to the output file.
Details
Parameters are read in for their values, stringified and added to the object passed to Telemetry.log(). The selectionParameters property is tested for initialization by the subclass and if it exists, the value of its .getTelemetry() function is added to extraData, just as it is in the implementation of the build and rebuild telemetry, which is implemented in BulkScriptAction.ts
How it was tested
I've set configured another project to use this branch and I've observed the results of the telemetry from several calls of rush install, update, build, and rebuild, with many different combinations of parameters.