Environment Configuration property validation #2813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validating all properties
…by calling validate
EmmanuelOluyomi
requested review from
D4N14L,
apostolisms,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
EmmanuelOluyomi
changed the title
EmmanuelOluyomi
changed the title
…vironConfig # Conflicts: # build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml
octogonz
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on the previous PR, we discussed with Pete some additional changes to make to the EnvironmentConfiguration API, see comments here: #2705 (comment). This is to make rush EnvironmentConfiguration more user-friendly
Details
This allows the ability to read any EnvironmentConfiguration property at any time, without initialization. Also replaced initialize() to validate() call that will check all the variables which will throw an exception for malformed values.
How it was tested
Made sure all the unit test passed and fixed all errors found