-
Notifications
You must be signed in to change notification settings - Fork 183
Version bump to 9.38.0 #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version bump to 9.38.0 #3172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soft/roosterjs into u/nguyenvi/touch-selection
Add TouchPlugin to handle text selection by touch (Spec: For touch selection, move the cursor to the beginning or end of the word if they tap within 6 characters of the beginning/end. If not, then place the cursor where they originally tapped.)
…t for updated cursor position
Touch Selection - handle double tab
**Spec:**
Double tap on a word: Highlight the word or closest word if the user tapped on a space in between 2 words and open the Floatie Ribbon **(-> browser handles this)**
- note: if the user double taps on the open space after a word and there is no word on the right-side of the same, then highlight the first space of the wide gap
- note: if a user double taps on a character like a comma, period, colon, or semi-colon, then highlight that character
- note: if a user double taps on a bracket [,{,(,),},] that is next to a word, then highlight the word and not the bracket **(-> browser handles this)**
**Changes:**
- Fix:
+ reset `this.pointerEvent` to be `null `after trigger plugin event
+ use `setTimeout` to delay plugin event triggered for 200s to wait for new selection to be updated properly before defining the reposition (and also wait for `dblclick` event to check if it is double tab or single tab).
- Listen to `dblclick` native event to trigger `pointerDoubleClick` if there is pointer event stored
- Add new `pointerDoubleClick` plugin event and add handler in Touch Plugin
- Add handler for 2 scenarios:
+ double clicked character is a punctuation mark: select that char only
+ double clicked character is a white space: check if right side has word, if yes, let browser handle it; if no, traverse to left and select the first white space char of the selected open space
…tion Touch Plugin - Handle the entire flow of touch selection (not rely on browser)
…m/microsoft/roosterjs into u/nguyenvi/fix-touch-context-menu
…menu Touch - Fix selection range collapsed issue when pressing touch on a word
* add role format handler * one line change to rerun checks
* Support CloneIndependentRoot feature * fix build
…/roosterjs into u/nguyenvi/fix-touch-1
Fix touch issue when re-clicking inside editor
JiuqingSong
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{
"react": "9.0.2",
"main": "9.38.0",
"legacyAdapter": "8.65.0",
"overrides": {}
}