Skip to content

Comments

feat(dep-check): all deps should be checked under --vigilant#932

Merged
tido64 merged 2 commits intomainfrom
tido/vigilant-also-checks-configured
Dec 3, 2021
Merged

feat(dep-check): all deps should be checked under --vigilant#932
tido64 merged 2 commits intomainfrom
tido/vigilant-also-checks-configured

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Dec 3, 2021

Description

By default, dep-check does not check dependencies that are not listed under capabilities. It assumes that the authors know what they are doing and want to manage them manually. The behaviour is the same even when --vigilant is specified. This leads to inconsistencies because unconfigured packages can be updated while configured ones are skipped.

Test plan

Tests should pass.

@tido64 tido64 requested a review from kelset December 3, 2021 13:42
@github-actions github-actions bot added the feature: align-deps This is related to align-deps label Dec 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Dependencies are potentially misaligned – run yarn rnx-dep-check locally for more details

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen in action this morning 👍 Great improvement to ensure that all the dependencies (even the ones not declared in a capability section) are aligned when using vigilant.

@tido64 tido64 merged commit 32b681b into main Dec 3, 2021
@tido64 tido64 deleted the tido/vigilant-also-checks-configured branch December 3, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: align-deps This is related to align-deps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants