feat(dep-check): all deps should be checked under --vigilant#932
Merged
feat(dep-check): all deps should be checked under --vigilant#932
Conversation
Contributor
|
Dependencies are potentially misaligned – run
|
kelset
approved these changes
Dec 3, 2021
Contributor
kelset
left a comment
There was a problem hiding this comment.
Seen in action this morning 👍 Great improvement to ensure that all the dependencies (even the ones not declared in a capability section) are aligned when using vigilant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By default, dep-check does not check dependencies that are not listed under
capabilities. It assumes that the authors know what they are doing and want to manage them manually. The behaviour is the same even when--vigilantis specified. This leads to inconsistencies because unconfigured packages can be updated while configured ones are skipped.Test plan
Tests should pass.