Skip to content

ci: shorten @rnx-kit/cli build time for test apps #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tido64 merged 1 commit into from
Feb 24, 2026
+15 −6
Merged

ci: shorten @rnx-kit/cli build time for test apps #3992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/nx.min.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "nx/presets/npm.json",
"defaultBase": "main",
"targetDefaults": {
"build": {
"dependsOn": ["^build"],
"cache": false
}
}
}
4 changes: 4 additions & 0 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ jobs:
- name: Build @rnx-kit/cli
if: ${{ steps.affected-projects.outputs.android != '' }}
run: |
cp .github/nx.min.json nx.json
yarn nx build @rnx-kit/cli
- name: Build Android app
if: ${{ steps.affected-projects.outputs.android != '' }}
Expand Down Expand Up @@ -179,6 +180,7 @@ jobs:
- name: Build @rnx-kit/cli
if: ${{ steps.affected-projects.outputs.ios != '' }}
run: |
cp .github/nx.min.json nx.json
yarn nx build @rnx-kit/cli
- name: Install Pods
uses: microsoft/react-native-test-app/.github/actions/cocoapods@trunk
Expand Down Expand Up @@ -223,6 +225,7 @@ jobs:
- name: Build @rnx-kit/cli
if: ${{ steps.affected-projects.outputs.macos != '' }}
run: |
cp .github/nx.min.json nx.json
yarn nx build @rnx-kit/cli
- name: Install Pods
uses: microsoft/react-native-test-app/.github/actions/cocoapods@trunk
Expand Down Expand Up @@ -267,6 +270,7 @@ jobs:
- name: Build @rnx-kit/cli
if: ${{ steps.affected-projects.outputs.windows != '' }}
run: |
cp .github/nx.min.json nx.json
yarn nx build @rnx-kit/cli
- name: Generate Visual Studio solution
if: ${{ steps.affected-projects.outputs.windows != '' }}
Expand Down
7 changes: 1 addition & 6 deletions nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"extends": "nx/presets/npm.json",
"defaultBase": "main",
"namedInputs": {
"default": ["{projectRoot}/**/*", "sharedGlobals"],
"sharedGlobals": [
"{workspaceRoot}/.github/workflows/pr.yml",
"{workspaceRoot}/nx.json",
"{workspaceRoot}/packages/eslint-config/*",
"{workspaceRoot}/packages/eslint-plugin/*",
"{workspaceRoot}/packages/jest-preset/*",
Expand Down Expand Up @@ -37,10 +37,5 @@
"dependsOn": ["build"],
"cache": true
}
},
"pluginsConfig": {
"@nx/js": {
"analyzeSourceFiles": false
}
Comment on lines -40 to -44
Copy link
Contributor

@Saadnajmi Saadnajmi Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we get this by extending the base preset now?

Copy link
Member Author

@tido64 tido64 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the npm preset includes this bit

}
}
Loading