chore(yarn-plugin-external-workspaces): Change where the bundle is stored in the repo #3579
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the produced bundle for the external-workspaces yarn plugin was built in the dist folder and published, but not tracked via git. A copy of it was tracked by git in the yarn plugin cache. This meant that to update the bundle used in the repository it would either need to be manually copied over or updated via the yarn plugin import command (which has the side effect of wiping out all our comments in the yarn configuration file.
Instead this adds the produced bundle to the repo, removes it from the plugin cache (effectively moving the file), then just references the dist folder directly. This avoids the multistep process and feels like a more standard pattern to follow.