fix(cli): automatically compose source maps for Hermes bundle#2915
Merged
fix(cli): automatically compose source maps for Hermes bundle#2915
Conversation
357d723 to
99c0f6b
Compare
99c0f6b to
996348f
Compare
Member
Author
kelset
approved these changes
Jan 17, 2024
Contributor
kelset
left a comment
There was a problem hiding this comment.
changes LGTM; tested locally and it works fine, and we already have the confirmation that it works. Let's ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automatically compose source maps of the JS bundle and Hermes bytecode bundle.
Test plan
Verify that
dist/main+esbuild.android.hbc.mappoints to source files instead ofdist/main+esbuild.android.bundle