fix(metro-config): fix out-of-tree platforms not being included on react-native 0.72

[tido64]

Description

Fix compatibility with react-native 0.72

Resolves #2466.

Test plan

n/a

[acoates-ms]

error Invalid platform "windows" selected.
info Available platforms are: "android", "ios". If you are trying to bundle for an out-of-tree platform, it may not be installed.

I get the following error due to the new default config not picking up the remaining part of the metro-config which was previously in the getDefaultConfig from the CLI. https://github.com/react-native-community/cli/blob/1796cdd794979dcf37ba5c7ec4303154bb71d56c/packages/cli-plugin-metro/src/tools/loadMetroConfig.ts#LL44C5-L44C5 -- I'm sure we need the other parts of this config too.

[kelset]

LGTM; let's also do what Andrew says in the profile (which I think you might have already done by now)

[tido64]

LGTM; let's also do what Andrew says in the profile (which I think you might have already done by now)

I've added a new capability:

Still looking into the invalid platform windows error. I get no complaints in react-native-test-app. But it fails in rnx-kit.

[tido64]

@acoates-ms: My testing was flawed, so I didn't repro the issue correctly. The issue was that @rnx-kit/metro-config overrides resolver.platforms regardless of what we set earlier. Anyway, with the new changes, we should no longer call getDefaultConfig from metro-service. We should instead expect a full config from the user. This means that we have to fix @rnx-kit/metro-config so that it correctly handles out-of-tree platforms.

This also means that @react-native/metro-config as is will break react-native-macos/-windows. Any suggestions for how we should approach here? Fixing upstream seems like the right thing to do, but it adds complexity as you can see in this PR. Actually, I don't think this is correct. CLI seems to be appending stuff after the fact, which is technically no longer correct.

[tido64]

@acoates-ms: In any case, I think this is as correct as I can make it. Can you verify on your side that it works?

[acoates-ms]

@acoates-ms: In any case, I think this is as correct as I can make it. Can you verify on your side that it works?

Yup, I was able to bundle with these changes.