fix(metro-service): avoid spinning up the file watcher #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparshaSaha
reviewed
Apr 11, 2023
| @@ -87,7 +87,7 @@ export async function bundle( | |||
| platform: args.platform, | |||
| unstable_transformProfile: args.unstableTransformProfile, | |||
| }; | |||
| const server = new Server(config); | |||
| const server = new Server(config, { watch: false }); | |||
There was a problem hiding this comment.
After this change will we be able to still spin up the file watcher if we want? Rather than hardcoding this as false, shall it make sense to take this option as an input?
There was a problem hiding this comment.
Why would you want to watch the files for a bundle command?
If you are starting a metro server then it would make sense. But I believe this code is only hit in the single bundle case, in which case spinning up a watcher is just overhead.
|
In OMR at least we were hitting this case at the top of the function, so this change would not be sufficient. const buildBundleWithConfig = getBundlerFromCliPlugin();
if (buildBundleWithConfig) {
return buildBundleWithConfig(args, config, output);
} |
auto-merge was automatically disabled
April 14, 2023 12:01
Pull request was converted to draft
|
Closing as this fix doesn't apply to newer versions of the CLI, and I don't have time to do proper testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid spinning up the file watcher when bundling.
Resolves #2332.
Test plan
n/a