Skip to content

Comments

docs(align-deps): update README#1931

Merged
tido64 merged 5 commits intomicrosoft:mainfrom
tido64:tido/align-deps/update-readme
Oct 18, 2022
Merged

docs(align-deps): update README#1931
tido64 merged 5 commits intomicrosoft:mainfrom
tido64:tido/align-deps/update-readme

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Oct 13, 2022

Description

Update README.

Test plan

n/a

@tido64 tido64 added the feature: align-deps This is related to align-deps label Oct 13, 2022
@tido64 tido64 mentioned this pull request Oct 13, 2022
24 tasks
@tido64 tido64 force-pushed the tido/align-deps/update-readme branch 2 times, most recently from ff4d188 to 63b1622 Compare October 14, 2022 15:14
@tido64 tido64 force-pushed the tido/align-deps/update-readme branch from 63b1622 to 78f9c14 Compare October 14, 2022 15:21
Comment on lines 10 to 11
`@rnx-kit/align-deps` manages dependencies for an npm package, based on its
needs and requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider expanding on this, explaining what align-deps does in some high-level detail, using words rather than code/bullets. A few sentences to contextualize it and introduce concepts like:

  • aligning dependencies is important for compatibility
  • built around preset, requirements, and capabilities (and briefly what these are and how they work together)
  • ships with presets that capture real-world compatibility data, and is extensible so you can add your own
  • you can use the command line, or get a richer experience through package configuration
  • works well in monorepos and across them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, below, when they read your examples and more technical info, they'll have a picture in mind of what it means and why it is the way it is.

Copy link
Member Author

@tido64 tido64 Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some more words, but I didn't want to make it too long. I know a lot of people just want to get started without having to read too much documentation. Maybe it makes more sense to forward people to https://microsoft.github.io/rnx-kit/docs/architecture/dependency-management somewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds ok to me. Maybe put it at the end of the intro paragraph?

Then also update that guide so it has the right terminology :)

@tido64 tido64 enabled auto-merge (squash) October 18, 2022 07:20
@tido64 tido64 merged commit e77b03b into microsoft:main Oct 18, 2022
@tido64 tido64 deleted the tido/align-deps/update-readme branch October 18, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: align-deps This is related to align-deps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants