Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): add support for @react-native-community/cli 7.0.3 #1484

Merged
merged 1 commit into from
May 10, 2022
Merged

fix(cli): add support for @react-native-community/cli 7.0.3 #1484

merged 1 commit into from
May 10, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 10, 2022

Description

The return type of createDevServerMiddleware() changed in react-native-community/cli#1560.

Resolves #1483.

Test plan

git clone https://github.com/fbeccaceci/rnx-kit-issue-example.git
cd rnx-kit-issue-example
yarn
npx react-native rnx-start

@tido64 tido64 added the feature: cli This is related to CLI label May 10, 2022
@afoxman afoxman mentioned this pull request May 10, 2022
Closed
5 tasks
@tido64 tido64 merged commit b864d94 into microsoft:main May 10, 2022
@tido64 tido64 deleted the tido/fix-cli-metro-0.67 branch May 10, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afoxman afoxman afoxman approved these changes

@kelset kelset Awaiting requested review from kelset

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: cli This is related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attachToServer is not a function. on empty project
2 participants
@tido64 @afoxman