Move request cancellations to a separate log #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpetit
approved these changes
May 15, 2024
MihaZupan
force-pushed
the
cancellation-logs
branch
from
2959e44
to
ff8bdf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2195
This moves
RequestCanceled,RequestBodyCanceledandUpgradeRequestCanceledto a debug-level log.The only thing I'm not sure about is whether
ForwardingRequestCancelledis the right name for it in case we decide to switch more errors to it in the future.Most of the change is switching error tests to use a shared helper that now also asserts that the error was logged.