Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notExists to true when value is empty #2412

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

qianyuansun
Copy link
Contributor

Currently Exists and NotExists are the same when value is empty. Headers with empty values have no semantic meaning in HTTP. So I updated NotExists with empty value to true. This will go against the current behavior by design.
Feel free to post any comments or suggestions. Initial discussion is here #2258 (comment)

@qianyuansun
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
This makes sense to me to get the behavior that Exists is always !NotExists.

I'll bring it up with the team as well given that this is a breaking change in behavior.

@MihaZupan MihaZupan added this to the v.Next milestone Feb 27, 2024
Copy link
Member

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage: we're okay with this even though it is technically a breaking change.

@adityamandaleeka adityamandaleeka merged commit e672f15 into microsoft:main Mar 5, 2024
7 checks passed
@MihaZupan MihaZupan modified the milestones: v.Next, YARP 2.2.0-preview1 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants