Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic Otel distributed tracing instructions #2395

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

andrejpk
Copy link
Contributor

@andrejpk andrejpk commented Feb 7, 2024

See #2394 : Docs don't give a generic OTel example and don't explain the need to include AddHttpClientInstrumentation for this to work. (This is obscured because Azure Monitor/App Insights do this for you automatically but if you're doing vanilla OTel, it's on you.)

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

docs/docfx/articles/distributed-tracing.md Outdated Show resolved Hide resolved
@MihaZupan MihaZupan marked this pull request as ready for review February 20, 2024 06:56
@MihaZupan MihaZupan added this to the v.Next milestone Feb 20, 2024
@MihaZupan MihaZupan enabled auto-merge (squash) February 20, 2024 06:57
@MihaZupan MihaZupan merged commit 5a08c6c into microsoft:release/latest Feb 20, 2024
6 checks passed
MihaZupan added a commit to MihaZupan/reverse-proxy that referenced this pull request Feb 20, 2024
* Add generic Otel instructions

* Update link

---------

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
MihaZupan added a commit that referenced this pull request Feb 27, 2024
* Add generic Otel instructions

* Update link

---------

Co-authored-by: Andrej Kyselica <andrej@kyselica.com>
@MihaZupan MihaZupan added the Type: Documentation Improvements or additions to documentation label Mar 25, 2024
@MihaZupan MihaZupan modified the milestones: v.Next, YARP 2.2.0-preview1 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants