Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Query Parameter MatchPolicy #1277

Merged
merged 9 commits into from
Oct 8, 2021
Merged

Conversation

ksauce
Copy link
Contributor

@ksauce ksauce commented Oct 6, 2021

Add query parameter match policy which is similar to the header match policy
Add NotContains to header match policy

add Contains to header policy
next: add NotContains both,  add sample projects and update docs
add QueryParameterMatchPolicy to ProxyEndpointFactory
@Tratcher Tratcher self-assigned this Oct 6, 2021
@Tratcher
Copy link
Member

Tratcher commented Oct 6, 2021

This also fixes #1235

@Tratcher
Copy link
Member

Tratcher commented Oct 6, 2021

Can you check on the failures in these tests?
https://github.com/microsoft/reverse-proxy/blob/main/test/Kubernetes.Tests/IngressConversionTests.cs
I think you just need to update their baseline files like this one:

@ksauce
Copy link
Contributor Author

ksauce commented Oct 6, 2021

yes fixed that. thanks

@ksauce ksauce closed this Oct 6, 2021
@ksauce ksauce reopened this Oct 6, 2021
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only made it through the docs so far.

src/ReverseProxy/Routing/QueryParameterMatcherPolicy.cs Outdated Show resolved Hide resolved
docs/docfx/articles/header-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Show resolved Hide resolved
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really good. Don't worry, most of my feedback is for little stuff. We should be able to work through it quickly.

src/ReverseProxy/Configuration/HeaderMatchMode.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Configuration/QueryParameterMatchMode.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Configuration/QueryParameterMatchMode.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Configuration/RouteMatch.cs Show resolved Hide resolved
src/ReverseProxy/Configuration/RouteQueryParameter.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Routing/QueryParameterMatcher.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Routing/QueryParameterMatcherPolicy.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Routing/QueryParameterMatcherPolicy.cs Outdated Show resolved Hide resolved
docs/docfx/articles/header-routing.md Outdated Show resolved Hide resolved
docs/docfx/articles/queryparameter-routing.md Outdated Show resolved Hide resolved
src/ReverseProxy/Configuration/RouteHeader.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Configuration/RouteQueryParameter.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Routing/HeaderMatcherPolicy.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Routing/QueryParameterMatcherPolicy.cs Outdated Show resolved Hide resolved
@Tratcher Tratcher added this to the YARP RC1 milestone Oct 8, 2021
@Tratcher Tratcher merged commit e74dade into microsoft:main Oct 8, 2021
@Tratcher
Copy link
Member

Tratcher commented Oct 8, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants