Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster to ConfigureRouteAsync #1231

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Add cluster to ConfigureRouteAsync #1231

merged 4 commits into from
Sep 7, 2021

Conversation

Kahbazi
Copy link
Collaborator

@Kahbazi Kahbazi commented Sep 3, 2021

Fixes #1229

Kahbazi
Kahbazi commented Sep 4, 2021
View reviewed changes
.editorconfig
@@ -231,7 +231,7 @@ csharp_using_directive_placement = outside_namespace:error

# New-line options
# https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-formatting-conventions?view=vs-2019#new-line-options
csharp_new_line_before_open_brace = methods, properties, control_blocks, types, anonymous_methods, lambdas, object_collection_array_initializers
csharp_new_line_before_open_brace = methods, properties, control_blocks, types, anonymous_methods, lambdas, object_collection_array_initializers, accessors
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was bugging me for a while.

test/ReverseProxy.Tests/Management/ProxyConfigManagerTests.cs Show resolved Hide resolved
Tratcher
Tratcher reviewed Sep 7, 2021
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For triage: While this is a breaking API change, it's not in the primary code path so the impact should be small.

src/ReverseProxy/Management/ProxyConfigManager.cs Outdated Show resolved Hide resolved
@Tratcher Tratcher merged commit bda7ace into microsoft:main Sep 7, 2021
@Tratcher
Copy link
Member

Tratcher commented Sep 7, 2021

Thanks

@Tratcher Tratcher added this to the YARP RC1 milestone Sep 7, 2021
@Kahbazi Kahbazi deleted the kahbazi/ConfigFilter branch September 7, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@alnikola alnikola Awaiting requested review from alnikola

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

Assignees
No one assigned
Labels
Breaking-Change
Projects
None yet
Milestone
YARP 1.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Add Cluster parameter to IProxyConfigFilter.ConfigureRouteAsync
3 participants
@Kahbazi @Tratcher @alnikola