Skip to content

Pass CancellationToken to HttpContent.ReadAsStreamAsync for .Net 5.0 #770

New issue
New issue
Closed
#1769
Closed
Pass CancellationToken to HttpContent.ReadAsStreamAsync for .Net 5.0#770
#1769

Description

@Kahbazi

Kahbazi
openedon Feb 19, 2021

A new overload for HttpContent.ReadAsStreamAsync is introduced in .Net 5.0 which gets CancellationToken. Should it be used?

reverse-proxy/src/ReverseProxy/Service/Proxy/HttpProxy.cs

Line 481 in b734f19

using var destinationStream = await destinationResponse.Content.ReadAsStreamAsync();

reverse-proxy/src/ReverseProxy/Service/Proxy/HttpProxy.cs

Line 533 in b734f19

using var destinationResponseStream = await destinationResponseContent.ReadAsStreamAsync();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Type: IdeaThis issue is a high-level idea for discussion.

Type

No type

Projects

YARP 2.x

  • Status

    ✅ Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions