Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forecasting #2499

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Support forecasting #2499

merged 1 commit into from
Jan 31, 2024

Conversation

jamesbchao
Copy link
Contributor

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6973ee4) 83.05% compared to head (08cd5a8) 90.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
+ Coverage   83.05%   90.70%   +7.64%     
==========================================
  Files          65       59       -6     
  Lines        3169     2334     -835     
==========================================
- Hits         2632     2117     -515     
+ Misses        537      217     -320     
Flag Coverage Δ
unittests 90.70% <ø> (+7.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesbchao jamesbchao force-pushed the jbchao/enable-what-if branch 2 times, most recently from 107bc3c to 07c42a3 Compare January 22, 2024 22:09
1 similar comment
1 similar comment
@@ -4,4 +4,5 @@ pytest-mock==3.6.1

requirements-parser==0.2.0
rai_test_utils[object_detection]
scikit-learn<=1.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed now as I've made the tests work with latest scikit-learn in the PR:
#2507

@imatiach-msft imatiach-msft merged commit 5036435 into main Jan 31, 2024
101 checks passed
@imatiach-msft imatiach-msft deleted the jbchao/enable-what-if branch January 31, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants