Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
rai_core_flask
introduces changes related to configuring private links and generating correct URLs. The most important changes include adding a new parameter to the__init__
method of theFlaskHelper
class to indicate whether it is a private link, and adding logic to construct thebase_url
andnbvm_origins
in the__init__
method of theAzureNBEnvironment
class based on theis_private_link
flag.Main changes:
rai_core_flask/flask_helper.py
: Added a new parameteris_private_link
to the__init__
method of theFlaskHelper
class, allowing the configuration of a flag indicating whether it is a private link or not.rai_core_flask/environments/azure_nb_environment.py
: Added logic to construct thebase_url
andnbvm_origins
in the__init__
method of theAzureNBEnvironment
class based on theis_private_link
flag, allowing for the generation of correct URLs.This was done due to a typo in the shown URL format, which is supposed to have the port at the end for PL workspaces:
Description
Checklist