Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Link URL support #2493

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Private Link URL support #2493

merged 3 commits into from
Jan 19, 2024

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Jan 18, 2024

This pull request to rai_core_flask introduces changes related to configuring private links and generating correct URLs. The most important changes include adding a new parameter to the __init__ method of the FlaskHelper class to indicate whether it is a private link, and adding logic to construct the base_url and nbvm_origins in the __init__ method of the AzureNBEnvironment class based on the is_private_link flag.

Main changes:

  • rai_core_flask/flask_helper.py: Added a new parameter is_private_link to the __init__ method of the FlaskHelper class, allowing the configuration of a flag indicating whether it is a private link or not.
  • rai_core_flask/environments/azure_nb_environment.py: Added logic to construct the base_url and nbvm_origins in the __init__ method of the AzureNBEnvironment class based on the is_private_link flag, allowing for the generation of correct URLs.

This was done due to a typo in the shown URL format, which is supposed to have the port at the end for PL workspaces:
image

image

image

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

1 similar comment
@Advitya17 Advitya17 merged commit 95d5e05 into main Jan 19, 2024
73 checks passed
@Advitya17 Advitya17 deleted the agemawat/pl_url branch January 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants