Fixing typo: roghly -> roughly #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Closed
deregtd
pushed a commit
that referenced
this pull request
Sep 18, 2017
deregtd
added a commit
that referenced
this pull request
Sep 19, 2017
…nitions (#280) * Rename #1 for ViewBase to fix caps * Rename #2 to fix ViewBase. Enabling forceConsistentCasingInFileNames. * Enabling noImplicitReturns, fixing a bug in native-common/Linking.ts * Enabling noImplicitThis * Enabling noUnusedLocals and fixing some bugs it found * Enabling strict null checks on reactxp * Addressing PR feedback * Fixing a bunch of type exporting/checking issues * Fixed a bunch of base interfaces and made everything inherit from them. Made the exported reactxp.ts files per-platform export types from the base classes instead of their specific implementation. This brought a bunch of interface holes to the surface.
ladipro
added a commit
to ladipro/reactxp
that referenced
this pull request
Feb 23, 2018
- reset CustomScrollbar._asyncInitTimer to undefined when it fires - made the deferred work in FocusManager idempotent
erictraut
pushed a commit
that referenced
this pull request
Feb 23, 2018
* Sync layout: Don't touch view container until _reportLayoutChange fires Reading container.offsetLeft, container.Top etc. triggers layout recalculation and unnecessarily stalls JS execution. Fixed in this commit by always subscribing to _reportLayoutChange and pushing our logic down to the deferred callback. * Sync layout: Defer initial CustomScrollbar sizing Asking for viewport dimensions triggers layout recalculation and unnecessarily stalls JS execution. Scrollbars having the exact correct size on first render is arguably not worth the perf hit (much less so when they are initially hidden which is the common case). Also deferring _tryLtrOverride() for the same reason. It's not clear when the neutral override class would actually be used. Maybe this whole thing can be removed? (Apologies, my web-fu is weak.) * Sync layout: Defer problematic tabIndex changes Setting tabIndex to -1 on an element that's active triggers layout recalculation and unnecessarily stalls JS execution. Defer this work to the next timer tick. * Addressed feedback #1 - reset CustomScrollbar._asyncInitTimer to undefined when it fires - made the deferred work in FocusManager idempotent * Revert "Sync layout: Don't touch view container until _reportLayoutChange fires" This reverts commit ef5e701. * Sync layout: Defer _checkAndReportLayout after showing a popup Checking layout after showing a popup triggers layout recalculation and unnecessarily stalls JS execution. Avoid that by deferring this work under these specific circumstances.
berickson1
pushed a commit
to berickson1/reactxp
that referenced
this pull request
Oct 22, 2018
…nitions (microsoft#280) * Rename microsoft#1 for ViewBase to fix caps * Rename microsoft#2 to fix ViewBase. Enabling forceConsistentCasingInFileNames. * Enabling noImplicitReturns, fixing a bug in native-common/Linking.ts * Enabling noImplicitThis * Enabling noUnusedLocals and fixing some bugs it found * Enabling strict null checks on reactxp * Addressing PR feedback * Fixing a bunch of type exporting/checking issues * Fixed a bunch of base interfaces and made everything inherit from them. Made the exported reactxp.ts files per-platform export types from the base classes instead of their specific implementation. This brought a bunch of interface holes to the surface.
berickson1
pushed a commit
to berickson1/reactxp
that referenced
this pull request
Oct 22, 2018
* Sync layout: Don't touch view container until _reportLayoutChange fires Reading container.offsetLeft, container.Top etc. triggers layout recalculation and unnecessarily stalls JS execution. Fixed in this commit by always subscribing to _reportLayoutChange and pushing our logic down to the deferred callback. * Sync layout: Defer initial CustomScrollbar sizing Asking for viewport dimensions triggers layout recalculation and unnecessarily stalls JS execution. Scrollbars having the exact correct size on first render is arguably not worth the perf hit (much less so when they are initially hidden which is the common case). Also deferring _tryLtrOverride() for the same reason. It's not clear when the neutral override class would actually be used. Maybe this whole thing can be removed? (Apologies, my web-fu is weak.) * Sync layout: Defer problematic tabIndex changes Setting tabIndex to -1 on an element that's active triggers layout recalculation and unnecessarily stalls JS execution. Defer this work to the next timer tick. * Addressed feedback microsoft#1 - reset CustomScrollbar._asyncInitTimer to undefined when it fires - made the deferred work in FocusManager idempotent * Revert "Sync layout: Don't touch view container until _reportLayoutChange fires" This reverts commit ef5e701. * Sync layout: Defer _checkAndReportLayout after showing a popup Checking layout after showing a popup triggers layout recalculation and unnecessarily stalls JS execution. Avoid that by deferring this work under these specific circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.