Skip to content

[0.64] Port windows fork of Pressable to win32 #9350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 10, 2022
Merged

[0.64] Port windows fork of Pressable to win32 #9350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e4aa699
Port windows fork of Pressable to win32 (#9132)
Saadnajmi Jan 8, 2022
f9fa432
redo overrides from windows fork
Saadnajmi Jan 8, 2022
217903e
Merge branch '0.64-stable' into pressable-win32-64
Saadnajmi Jan 8, 2022
987e8ef
yarn lint:fix + some lines I forgot to copy
Saadnajmi Jan 8, 2022
ead9083
move to other path
Saadnajmi Jan 8, 2022
bc4f30d
validate-overrides
Saadnajmi Jan 8, 2022
616ddc2
yarn lint:fix again
Saadnajmi Jan 8, 2022
7ae1d0c
Merge branch 'pressable-win32-64' of github.com:Saadnajmi/react-nativ…
Saadnajmi Jan 8, 2022
73022c7
forgot some props
Saadnajmi Jan 8, 2022
d29ea1a
move one more file
Saadnajmi Jan 8, 2022
530becc
lint:fix once more
Saadnajmi Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@office-iss-react-native-win32-dd07e0e2-ca29-4722-b473-36dc41e699ce.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Port windows pressable with extra desktop support to win32",
"packageName": "@office-iss/react-native-win32",
"email": "saadnajmi2@gmail.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/react-native-windows-06381c40-100f-42e5-a931-427f39f7375a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fork HoverState.js to allow hover events on Pressable",
"packageName": "react-native-windows",
"email": "saadnajmi2@gmail.com",
"dependentChangeType": "patch"
}
4 changes: 4 additions & 0 deletions packages/@react-native-windows/tester/src/js/examples/Pressable/PressableExample.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ function PressableFeedbackEvents() {
testID="pressable_feedback_events_button"
accessibilityLabel="pressable feedback events"
accessibilityRole="button"
// [Windows
onHoverIn={() => appendEvent('hover in')}
onHoverOut={() => appendEvent('hover out')}
// Windows]
onPress={() => appendEvent('press')}
onPressIn={() => appendEvent('pressIn')}
onPressOut={() => appendEvent('pressOut')}
Expand Down
Loading