Use shared pointer in WebSocket MessageReceived #9293

JunielKatarn · 2021-12-17T00:28:44Z

Currently, the asynchronous callback for incoming WebSocket messages is defined in a member function and registered as follows:

m_socket.MessageReceived({this, &WinRTWebSocketResource::OnMessageReceived});

This will make access to WinRTWebSocketResource's callbacks invalid if the class instance has already been destroyed.

This change prevents an access violation during IMessageWebSocket::MessageReceived by keeping a strong reference to the WinRTWebSocketResource instance, moving the definition from a member method to a capturing lambda:

  m_socket.MessageReceived(
      [self = shared_from_this()](IWebSocket const &sender, IMessageWebSocketMessageReceivedEventArgs const &args) {
...

See https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/handle-events#delegate-types-for-asynchronous-actions-and-operations

Microsoft Reviewers: Open in CodeFlow

… wsrc-onmsg-ptr

NikoAri · 2021-12-17T00:57:11Z

m_connectPerformedPromise.get_future().wait();

Hmm, why is this wait and synchronization needed?

Refers to: vnext/Shared/WinRTWebSocketResource.cpp:292 in dd2e5a7. [](commit_id = dd2e5a7, deletion_comment = False)

NikoAri

JunielKatarn · 2021-12-17T01:10:51Z

m_connectPerformedPromise.get_future().wait();
Hmm, why is this wait and synchronization needed?

Refers to: vnext/Shared/WinRTWebSocketResource.cpp:292 in dd2e5a7. [](commit_id = dd2e5a7, deletion_comment = False)

To ensure sequence of operations (connect must be resolved first).
This mechanism may be improved (i.e. using a dispatch queue).

vnext/Shared/WinRTWebSocketResource.cpp

ghost · 2021-12-17T01:12:34Z

Hello @JunielKatarn!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 9 hours 16 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

vnext/Shared/WinRTWebSocketResource.cpp

* Set MessageReceived to self-capturing lambda * clang format * Change files

NikoAri · 2021-12-21T00:47:54Z

vnext/Shared/WinRTWebSocketResource.cpp

@@ -330,6 +298,35 @@ void WinRTWebSocketResource::Synchronize() noexcept {
 #pragma region IWebSocketResource

 void WinRTWebSocketResource::Connect(string &&url, const Protocols &protocols, const Options &options) noexcept {
+  m_socket.MessageReceived(
+      [self = shared_from_this()](IWebSocket const &sender, IMessageWebSocketMessageReceivedEventArgs const &args) {


self

(nit) I'm also curious whether weak_ptr would make more sense here. If object is destroyed, it's probably not worth processing any MessageReceived on it.

* Avoid capturing raw `this` pointer in WebSocket module (#9247) * Use implicit (brace) constructor for getMethods() * Define CxxModuleHolder * Make m_asyncStorageManager shared_ptr * Change files * Initialize m_holder * Implement WebSocketModule::SharedState * Move ResourceFactory into shared state * Revert AsyncStorage changes * Add URL argument to IWebSocketResource::Connect * Drop URL from factory method * Update BeastWebSocketResource * Handle malformed Uris within ::Connect() * Remove urlString argument from IWebSocketResource::Make * Use constexpr for commont test URLs * Remove redundant move in to_hstring * Add/remove std::move where applicable Co-authored-by: Nick Gerleman <ngerlem@microsoft.com> * Use shared pointer in WebSocket MessageReceived (#9293) * Set MessageReceived to self-capturing lambda * clang format * Change files * Remove change files * Change files Co-authored-by: Nick Gerleman <ngerlem@microsoft.com>

* Avoid capturing raw `this` pointer in WebSocket module (#9247) * Use implicit (brace) constructor for getMethods() * Define CxxModuleHolder * Make m_asyncStorageManager shared_ptr * Change files * Initialize m_holder * Implement WebSocketModule::SharedState * Move ResourceFactory into shared state * Revert AsyncStorage changes * Add URL argument to IWebSocketResource::Connect * Drop URL from factory method * Update BeastWebSocketResource * Handle malformed Uris within ::Connect() * Remove urlString argument from IWebSocketResource::Make * Use constexpr for commont test URLs * Remove redundant move in to_hstring * Add/remove std::move where applicable Co-authored-by: Nick Gerleman <ngerlem@microsoft.com> * Use shared pointer in WebSocket MessageReceived (#9293) * Set MessageReceived to self-capturing lambda * clang format * Change files * Remove change files * Change files * Remove vnext/Shared/InspectorPackagerConnection.cpp * Empty Co-authored-by: Nick Gerleman <ngerlem@microsoft.com>

* Set MessageReceived to self-capturing lambda * clang format * Change files

* Use shared pointer in WebSocket MessageReceived (#9293) * Set MessageReceived to self-capturing lambda * clang format * Change files * Remove change files * Implement IHttpResource (#9484) * Added HttpResource skeleton * Import WINRT namespaces * Use custom struct instead of folly:dynamic in IHttpResource * Drop factory method from Beast HTTP resource * Move WinRT conversion utils into header * Move WinRT conversion utils into header * Define class WinRTHttpResource * Update HttpModule * Define IHttpResource::Response * Implement callback members * Implement AbortRequest * Implement multiple request handling * Drop client argument from PerformSendRequest * Use background thread in PerformSendRequest * Add WinRTConversions.cpp * Init resource in module * Implement test RequestGetSucceeds * Complete RequestGetSucceeds * Complete RequestGetFails * Add HttpModule to default modules * Move resume_in_queue back to WebSocket resource * Simplify WinRTConversions includes * Rename runtime option to Http.UseResourcedModule * clang format * Change files * Update x86 DLL boundary * Using SetRtOpt in InitModule * Add test RequestGetHeadersSucceeds * Allow aborting server * Use case-insensitive comparison for headers * Collect both response and content headers * Address feedback * Remove member function HttpModule::SendEvent * Remove SetOnRequest * Delete Beast HTTP resource * Catch specific exceptions where applicable * Rename Add/Remove Request to Track/Untrack Response * Use r-value references where applicable * Set runtime option Http.UseMonolithicModule * Define GetHttpModuleName and GetWebSocketModuleName * Remove WS, HTTP and Timing from Desktop test runner * Update XHRTest * Implement cxxCallback * Pass request ID to callbacks * Set default TestStatus for TestResult * Update XHR test * Format XHR test * Handle abrupt WebSocket connection interruption (#9829) * Add UnplugServer test * Handle exceptions in args.GetDataReader() * Consolidate catch clauses in MessageReceived * Change files * Delete change file * Remove change file * Change files Co-authored-by: dannyvv <dannyvv@microsoft.com>

* Use shared pointer in WebSocket MessageReceived (#9293) * Set MessageReceived to self-capturing lambda * clang format * Change files * Remove Change file * Implement IHttpResource (#9484) * Added HttpResource skeleton * Import WINRT namespaces * Use custom struct instead of folly:dynamic in IHttpResource * Drop factory method from Beast HTTP resource * Move WinRT conversion utils into header * Move WinRT conversion utils into header * Define class WinRTHttpResource * Update HttpModule * Define IHttpResource::Response * Implement callback members * Implement AbortRequest * Implement multiple request handling * Drop client argument from PerformSendRequest * Use background thread in PerformSendRequest * Add WinRTConversions.cpp * Init resource in module * Implement test RequestGetSucceeds * Complete RequestGetSucceeds * Complete RequestGetFails * Add HttpModule to default modules * Move resume_in_queue back to WebSocket resource * Simplify WinRTConversions includes * Rename runtime option to Http.UseResourcedModule * clang format * Change files * Update x86 DLL boundary * Using SetRtOpt in InitModule * Add test RequestGetHeadersSucceeds * Allow aborting server * Use case-insensitive comparison for headers * Collect both response and content headers * Address feedback * Remove member function HttpModule::SendEvent * Remove SetOnRequest * Delete Beast HTTP resource * Catch specific exceptions where applicable * Rename Add/Remove Request to Track/Untrack Response * Use r-value references where applicable * Set runtime option Http.UseMonolithicModule * Define GetHttpModuleName and GetWebSocketModuleName * Remove WS, HTTP and Timing from Desktop test runner * Update XHRTest * Implement cxxCallback * Pass request ID to callbacks * Set default TestStatus for TestResult * Update XHR test * Format XHR test * Handle abrupt WebSocket connection interruption (#9829) * Add UnplugServer test * Handle exceptions in args.GetDataReader() * Consolidate catch clauses in MessageReceived * Change files * Remove change file * Remove change file * Change files Co-authored-by: dannyvv <dannyvv@microsoft.com>

* Set MessageReceived to self-capturing lambda * clang format * Change files

* Use shared pointer in WebSocket MessageReceived (#9293) * Set MessageReceived to self-capturing lambda * clang format * Change files * remove change file * Implement IHttpResource (#9484) * Added HttpResource skeleton * Import WINRT namespaces * Use custom struct instead of folly:dynamic in IHttpResource * Drop factory method from Beast HTTP resource * Move WinRT conversion utils into header * Move WinRT conversion utils into header * Define class WinRTHttpResource * Update HttpModule * Define IHttpResource::Response * Implement callback members * Implement AbortRequest * Implement multiple request handling * Drop client argument from PerformSendRequest * Use background thread in PerformSendRequest * Add WinRTConversions.cpp * Init resource in module * Implement test RequestGetSucceeds * Complete RequestGetSucceeds * Complete RequestGetFails * Add HttpModule to default modules * Move resume_in_queue back to WebSocket resource * Simplify WinRTConversions includes * Rename runtime option to Http.UseResourcedModule * clang format * Change files * Update x86 DLL boundary * Using SetRtOpt in InitModule * Add test RequestGetHeadersSucceeds * Allow aborting server * Use case-insensitive comparison for headers * Collect both response and content headers * Address feedback * Remove member function HttpModule::SendEvent * Remove SetOnRequest * Delete Beast HTTP resource * Catch specific exceptions where applicable * Rename Add/Remove Request to Track/Untrack Response * Use r-value references where applicable * Set runtime option Http.UseMonolithicModule * Define GetHttpModuleName and GetWebSocketModuleName * Remove WS, HTTP and Timing from Desktop test runner * Update XHRTest * Implement cxxCallback * Pass request ID to callbacks * Set default TestStatus for TestResult * Update XHR test * Format XHR test * remove change file * Implement Origin Policy filter (#9771) * Move all awaitable code into PerformSendRequest * Await coroutine methods * Remove blank lines * Simplify co_return UntrackResponse * Use dynamic body for server internal request * Defne SetOnOptions * Move url before headers in Response type * Add dummy preflight filter * Update x64 exports * Use strand for server IO context * Use HTTP message aliases * Use HTTP message aliases * Do not keep session references Allows dropping server scope in tests. * Comment out server scopes * Use DynamicRequest|Response alias * Format * Use thread vector * Drop outdated boost package validation in ReactCommon * Define experimental write strand * Drop server scope in default test * Also pass server context to sessions * Disable resource in default test * Use Beast example * Remove unused sample code * Create HttpServer as listener wrapper * Pass callbacks down to session * Strong-name response as DynamicResponse * Use DynamicRequest in handle_request * Define HandleRequest as member function * Lambda-based Respond() * #if-out original sample code * Keep count on get: ReaGetSucceeds * Implement lambda_ using std::function * Run context in io thread * Join threads in Stop method * Port send lambda to MS::R::T::HttpServer * Update other basic tests * Ensure Get+Options sequencing * Clean up comments * Use Callbacks() method * Add concurrency argument * Reduce macro usage * Fix default OPTIONS handler * Ensure number of headers * Define ResponseType * Use ResponseWrapper for polymorphism * Define remaining wrapped types (File, String) * Clean up server code * (WIP) add test PreflightSucceeds * catch hresult_error * Use ProcessRequest result in PreformSendReq * Rename test header value to Requested * Propagate orror in ProcessRequest * Rename OPReqFilter to PrototypeReqFilter * Port request filter to WinRT IHttpFilter subtype * Define allowed/forbidden methods and headers * Define MSRN::Networking::OriginPolicyHttpFilter * Move networking types into Shared\Networking folder * Refactor: Move network types to Microsoft::React::Networking * Clean up commented inline * Make OPFilter::SendAsync non const * Remove PrototypeHttpFilter * Temporarily have desk.ITs depend on CppWinRT * Define test OriginPolicyHttpFilterTest::UrlsHaveSameOrigin * Add more same origin tests * Start implementing ValidateRequest * Finish ValidateRequest() * Rename SingleOrigin to SameOrigin * Implement SendPreflightAsync * Fix OP assignment and GetOrigin rendering * Parse Access-Control-Allow-Headers * Done extracting access control values * Use request as argument of ValidatePreflightResponse * clang format * Pass RequestArgs to request properties * Pass RequestArgs to ValidateAllowOrigin * Remove prototype non-WinRT filter * Implement CorsUnsafeNotForbiddenRequestHeaderNames * Test WinRT RequestHeader case sensitivity * Fix ValidateAllowOrigin 4.10.5 * Add HttpOriginPolicyIntegrationTest * Use boost:iequals to compare method names * Add server support for CONNECT and TRACE methods * Make HttpServer port uint16_t * Prelfight only when OP is CORS. - Add test SimpleCorsSameOriginSucceededs - Add test NoCorsCrossOriginPatchSucceededs - Add test NoCorsCrossOriginFetchRequestSucceeds - Add test HTTP Server support for PATCH * Use runtime option Http.StrictScheme * Drop namespace from OriginPolicy * Remove Origin from request heders * Clean includes and usings in WinRTHttpResource.cpp * Update preflight cache issue references (#9770) * Pass origin in IHttpResource constructor * clang format * Prevent nullptr access when iterating preflight request headers * Include request content headers in preflight headers list * Send preflight to original request URL. - Change test origin URL to non-existing http://example.rnw - Have OriginPolicyHttpFilter::SendRequestAsync catch hresult_error to avoid losing info in (...) clause. * Export APIs Set/GetRuntimeOptionString - Switch to class-level static origin Uri. - Define static (global) origin Uri via runtime option "Http.GlobalOrigin". * clang format * Implement TestOriginPolicy to parameterize OP tests * Clean up non-parameterized tests * Use constant for dummy cross origin * Simplify test param constructors * Start implementing ValidateResponse * Add more tests - FullCorsCrossOriginMissingCorsHeadersFails - FullCorsCrossOriginMismatchedCorsHeaderFails * clang format * Change files * Update namespaces in MSRN solution * Move RequestArgs and ResponseType into new header * Implement ExtractAccessControlValues - Validate test result against ServerParams::Response::result * Report specific origin mismatch errors in ValidatePreflightResponse * Declare FullCorsCrossOriginCheckFailsOnPreflightRedirectFails * Add ABI-safe runtime options free functions. - Microsoft_React_SetRuntimeOptionBool - Microsoft_React_SetRuntimeOptionInt - Microsoft_React_SetRuntimeOptionString - Microsoft_React_GetRuntimeOptionBool - Microsoft_React_GetRuntimeOptionInt - Microsoft_React_GetRuntimeOptionString * Drop namespaced GetRuntimeOptionString * Use case-insensitive comparison * Drop newline from error message * Return unmanaged copy in GetRuntimeOptionString * Update FullCorsCrossOriginCheckFailsOnPreflightRedirectFails args * Disallow preflight redirect. See https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSExternalRedirectNotAllowed * Replace winrt::get_self<D,I> with .as<D> * Drop LF from error messages * Use self-managed variable port in tests * Start writing FullCorsCorsCheckFailsOnResponseRedirectFails * Scope disabling autoredirect to preflight request only * Update TODOs with open issues * Compute originAllowed * Add test FullCorsSameOriginToSameOriginRedirectSucceeds * Test FullCorsSameOriginToCrossOriginRedirectSucceeds * Test FullCorsCrossOriginToOriginalOriginRedirectFails * Declare FullCorsCrossOriginToAnotherCrossOriginRedirectSucceeds * Implement OriginPolicyHttpFilter::ConstWcharComparer * Use _wcsicmp instead of boost::iequals in ConstWcharComparer * Correct SimpleCORS value search * Disable FullCorsCrossOriginWithCredentialsSucceeds for now * Rename type alias ResponseType to ResponseOperation * clang format * Handle originPolicy a request property instead of a member variable * Avoid iterating response headers while removing items * Gracefully fail when adding bad request headers - Write remaining integration tests * Use boost::iequals in PerformSendRequest * clang format * Use s_port for redirServer args * Rename TestOriginPolicy to TestOriginPolicyWithRedirect * Temporarily disabled tests - FullCorsCrossOriginToAnotherCrossOriginRedirectWithPreflightSucceeds - pending redirect - FullCorsRequestWithHostHeaderFails - Host request header is probematic * Use std::queue for nonSimpleNames * Finish ValidateResponse * Clean up comments * Add Test ExcludeHttpOnlyCookies * Add tests KeepNonHttpOnlyCookies, RemoveAllCookies * Address TODO comments * Always allow simple-CORS methods in preflight * Avoid auto for loop indexe sused against container .size() * Update Desktop.Test.DLL exports for ARM64 * Skip test FullCorsCrossOriginToAnotherCrossOriginRedirectSucceeds * Disable FullCorsCrossOriginToAnotherCrossOriginRedirectWithPreflightFails * Ignore SimpleCorsForbiddenMethodFails * Ignore SimpleCorsCrossOriginFetchFails * RequestWithProxyAuthorizationHeaderFails * Ignore SimpleCorsSameOriginSucceededs * Ignore NoCorsCrossOriginFetchRequestSucceeds * Revert "Ignore NoCorsCrossOriginFetchRequestSucceeds" This reverts commit b5445fb. * Revert "Ignore SimpleCorsSameOriginSucceededs" This reverts commit ab75c37. * Revert "RequestWithProxyAuthorizationHeaderFails" This reverts commit 70148b1. * Revert "Ignore SimpleCorsCrossOriginFetchFails" This reverts commit 982e450. * Revert "Ignore SimpleCorsForbiddenMethodFails" This reverts commit 869bda9. * Revert "Disable FullCorsCrossOriginToAnotherCrossOriginRedirectWithPreflightFails" This reverts commit e9e178a. * Revert "Skip test FullCorsCrossOriginToAnotherCrossOriginRedirectSucceeds" This reverts commit 6688e7d. * Skip OP integration tests * Empty commit * Use scoped_lock for runtime options * Testing signature * Have C++ Rt Option functions call ABI-safe ones * Ensure different ports for each netwk test class * Remove remaining hard-coded ports from WS tests * Use ABI-safe callback for GetRtOptString * Only insert boolean rt options when true * Use static variable for port in HttpResourceIntegrationTest * Add HttpResourceIntegrationTest::SimpleRedirectSucceeds * Move C++ Rt Optio APIs to new header CppRuntimeOptions.h * Implement internal Set/GetRuntimeOptionString * clang format * Rename Microsoft_React_* functions to MicrosoftReact* * Update nuspec * remove change file * Handle abrupt WebSocket connection interruption (#9829) * Add UnplugServer test * Handle exceptions in args.GetDataReader() * Consolidate catch clauses in MessageReceived * Change files * remove change file * Allow >10MB HTTP downloads (#9957) * Allow fetching HTTP content by segments * Change files * Restore the 10MB download chunk size * Remove usage of Content-Length * Revert segment size to 10MB * Make segmentSize and length uint32_t * Reuse response content buffer * remove change file * Implement Blob module (#9352) * Added BlobModule and IWSModuleContHandler headers * Implement Blob module * Avoid raw self pointer in BlobModule * Implement WebSocketModule msg processing * clang format * Don't return until websocketMessage event is sent * Define CreateBlobModule() * Add DEF exports * Add Blob JS tests * Add Blob JS tests * Change files * yarn lint * Add overrides * Register BlobModule in DesktopTestRunner * Keep ignoring WebSocketBlob test by default * Add BlobModule to default modules list * Allow 'blob' responseType in HTTP module * Ensure React Instance can be accessed when using older versions of react-native * Emit error message on createFromParts failure * Remove redundant extra modules in Desktop integration tests * Declare IWebSocketModuleProxy * Remove Blob and WS module factories from DLL boundary * Implement IWebSocketModuleProxy * clang format * Update packages.lock * Use winrt::array_view directly in ResolveMessage * Define InstanceImpl::m_transitionalModuleProperties * Include CreateModules.h in projects accessing MSRN.Cxx * Define WinRT class WebSocketModuleContentHandler - Have BlobModule constructor register the content handler in transitive property bag CxxNativeModule/WebSocketModuleContentHandler * Have WebSocketModule use IInspectable as props arg * Use property bag instead of global singletons for blob helpers * Store blob helpers in prop bag as weak_ptr * Replace remaining lock_guard<mutex> in BlobModule * Define IUriHandler, IReqBodyHandler, IRespHandler. * IHttpResource::SendRequest - add folly::dynamic data arg * Add data arg to test SendRequest calls * First implementation for BlobModuleUriHandler * Remove WebSocketModuleContentHandler WinRT class * Implement IBlobPersistor, MemoryBlobPersistor * clang format * Update yarn.lock * Update RctRootVieTagGen location * Implement addNetworkingHandler * Fix createFromParts buffer persistence * Drop WebSocketModule s_sharedState in favor of property bag * Disable back WebSocketBlob test * Rename iProperties to inspectableProperties * Pass ReactContext properties to CreateHttpModule in InstanceWin * Remove WebSocketModule constructor from x86 DLL boundary * yarn lint * Update packages.lock * Make transitional property bag non-member * Use blobURIScheme wherever possible * Pass request content as folly::dynaic. - Pass request ID directly from JavaScript layer. * Use constexpr for folly indexes * Implement GetMimeTypeFromUri * Finish BlobModule handler implementations. * Remove unused includes * Ensure HttpModule::m_resource is set * clang format * clang format * Allow blob responseType * Use winrt::to_hstring instead of Utf8ToUtf16 * Pass inspectableProperties down to WinRTHttpResource * Implement IHttpModuleProxy via WinRTHttpResource * Consume URI handler - IHttpResource - Rename SetOnRequest to SetOnRequestSuccess - Declare SetOnBlobData to pass complex (non-string) response data * Consume IRequestBodyHandler * Consume IResponseHandler * Ensure properties exist in bag before using value * Update packages lock * Add missing call to Modules::SendEvent * Fix Shared filters * Rename SetOnBlobData to SetOnData (different args) * Correctly retrieve blob slices * Correctly retrieve blob slices * Clang format * Update project filters * Drop BlobModuleUriHandler * Continue handling requests when not blob-supported * Add BlobTest * Update packages.lock.json * Define FileReaderModule * Implement FileReaderModule * Complete BlobTest * Make IBlobPersistor::ResolveMessage throw std::invalid_argument * Fail on Content-Encoding parsing even if no error handler * Remove MIME mappings. Currently unused * MemoryBlobPersistor::ResolveMessage throw on out of bounds * lint * Enable BlobTest by default * Disable Blob test in CI (may hang) * remove change file * Change files * clang format * Add missing boost imports * Downgrade C++/WinRT API usage * yarn lint * clang format * yarn lint * Skip RNTester Blob test * Disable BlobModule in UWP

JunielKatarn added 4 commits December 16, 2021 18:23

Set MessageReceived to self-capturing lambda

b6c6b31

clang format

2c6ec16

Change files

f48fdc1

Merge branch 'main' of github.com:microsoft/react-native-windows into…

dd2e5a7

… wsrc-onmsg-ptr

JunielKatarn requested a review from a team as a code owner December 17, 2021 00:28

JunielKatarn requested a review from a team December 17, 2021 00:29

NikoAri approved these changes Dec 17, 2021

View reviewed changes

JunielKatarn commented Dec 17, 2021

View reviewed changes

vnext/Shared/WinRTWebSocketResource.cpp Show resolved Hide resolved

JunielKatarn added Area: Networking AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) labels Dec 17, 2021

JunielKatarn requested a review from vmoroz December 17, 2021 01:19

dannyvv approved these changes Dec 17, 2021

View reviewed changes

vnext/Shared/WinRTWebSocketResource.cpp Show resolved Hide resolved

ghost merged commit 39c84d2 into microsoft:main Dec 17, 2021

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Dec 17, 2021

Use shared pointer in WebSocket MessageReceived (microsoft#9293)

14bbdbe

* Set MessageReceived to self-capturing lambda * clang format * Change files

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Dec 17, 2021

Use shared pointer in WebSocket MessageReceived (microsoft#9293)

02559cd

* Set MessageReceived to self-capturing lambda * clang format * Change files

This was referenced Dec 17, 2021

[0.67] Avoid capturing raw this pointer in WebSocket module #9296

Merged

[0.64] Avoid capturing raw this pointer in WebSocket module #9297

Merged

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Dec 17, 2021

Use shared pointer in WebSocket MessageReceived (microsoft#9293)

b9ceb14

* Set MessageReceived to self-capturing lambda * clang format * Change files

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Dec 17, 2021

Use shared pointer in WebSocket MessageReceived (microsoft#9293)

a743650

* Set MessageReceived to self-capturing lambda * clang format * Change files

This was referenced Dec 17, 2021

[0.66] Avoid capturing raw this pointer in WebSocket module #9298

Merged

[0.65] Avoid capturing raw this pointer in WebSocket module #9299

Merged

NikoAri reviewed Dec 21, 2021

View reviewed changes

JunielKatarn deleted the wsrc-onmsg-ptr branch December 30, 2021 01:09

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Apr 22, 2022

Use shared pointer in WebSocket MessageReceived (microsoft#9293)

6f388e0

* Set MessageReceived to self-capturing lambda * clang format * Change files

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Apr 22, 2022

Use shared pointer in WebSocket MessageReceived (microsoft#9293)

a7c2d7f

* Set MessageReceived to self-capturing lambda * clang format * Change files

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request May 21, 2022

Use shared pointer in WebSocket MessageReceived (microsoft#9293)

6fcd546

* Set MessageReceived to self-capturing lambda * clang format * Change files

JunielKatarn mentioned this pull request May 21, 2022

[0.66] Implement Blob module #9983

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use shared pointer in WebSocket MessageReceived #9293

Use shared pointer in WebSocket MessageReceived #9293

Uh oh!

JunielKatarn commented Dec 17, 2021 •

edited

Loading

Uh oh!

NikoAri commented Dec 17, 2021

Uh oh!

NikoAri left a comment

Uh oh!

JunielKatarn commented Dec 17, 2021

Uh oh!

Uh oh!

ghost commented Dec 17, 2021

Uh oh!

Uh oh!

NikoAri Dec 21, 2021

Uh oh!

Uh oh!

Use shared pointer in WebSocket MessageReceived #9293

Use shared pointer in WebSocket MessageReceived #9293

Uh oh!

Conversation

JunielKatarn commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

NikoAri commented Dec 17, 2021

Uh oh!

NikoAri left a comment

Choose a reason for hiding this comment

Uh oh!

JunielKatarn commented Dec 17, 2021

Uh oh!

Uh oh!

ghost commented Dec 17, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Uh oh!

NikoAri Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JunielKatarn commented Dec 17, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.