Conditionally fires onDismiss
when receiving ContentDialogResult::None
#8866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ContentDialog returns with a result of
None
, and there is no close button / neutral button option presented to the user, this change fires anonDismiss
instead of attempting to fire thebuttonNeutral.onPress
callback, which is very unlikely to be registered.It is very unlikely that RNW apps have leaned on this, but if someone is depending on the implementation detail of the "neutral" callback being called without presenting the button (by leaving the text for the neutral button option null), then this is a minor breaking change.
Fixes #8865
Microsoft Reviewers: Open in CodeFlow