Detect whether a project file is a dynamic library #8099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/exclude-application-projects
branch
from
c1f4bdc to
4de051f
Compare
tido64
force-pushed
the
tido/exclude-application-projects
branch
from
4de051f to
b93a2fd
Compare
|
@tido64 FYI looks like this is causing failures in auto-linking UTs. |
Thanks, I will take a look later. I got pulled into another thing 😄 |
asklar
reviewed
Jun 25, 2021
asklar
reviewed
Jun 25, 2021
asklar
approved these changes
Jun 25, 2021
|
@tido64 consider adding a unit test to make sure we don't regress this again? |
asklar
reviewed
Jun 25, 2021
packages/@react-native-windows/cli/src/e2etest/__snapshots__/dependencyConfig.test.ts.snap
Outdated
Show resolved
Hide resolved
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8072
Microsoft Reviewers: Open in CodeFlow